Re: [PATCH v3] staging: iio: adc: ad7816: use dev_err_probe() for GPIO lookups

From: Andy Shevchenko

Date: Thu Nov 19 2026 - 04:22:43 EST


On Wed, Nov 18, 2026 at 10:22:17AM -0800, Maximo Manriquez Lizarraga via B4 Relay wrote:
>
> GPIO lookups can return -EPROBE_DEFER. Convert the rdwr, convert,
> and busy GPIO lookup failures in ad7816_probe() to dev_err_probe(),
> which suppresses the error message on deferral and records the deferral
> reason.
>
> No functional change other than defer handling.

...

> static int ad7816_probe(struct spi_device *spi_dev)

While at it, add

struct device *dev = &spi_dev->dev;

at the top of the function and use in the code you have touched.

> chip->id = spi_get_device_id(spi_dev)->driver_data;
> chip->rdwr_pin = devm_gpiod_get(&spi_dev->dev, "rdwr", GPIOD_OUT_HIGH);
> - if (IS_ERR(chip->rdwr_pin)) {
> - ret = PTR_ERR(chip->rdwr_pin);
> - dev_err(&spi_dev->dev, "Failed to request rdwr GPIO: %d\n",
> - ret);
> - return ret;
> - }
> + if (IS_ERR(chip->rdwr_pin))
> + return dev_err_probe(&spi_dev->dev, PTR_ERR(chip->rdwr_pin),
> + "Failed to request rdwr GPIO\n");
> chip->convert_pin = devm_gpiod_get(&spi_dev->dev, "convert",
> GPIOD_OUT_HIGH);
> - if (IS_ERR(chip->convert_pin)) {
> - ret = PTR_ERR(chip->convert_pin);
> - dev_err(&spi_dev->dev, "Failed to request convert GPIO: %d\n",
> - ret);
> - return ret;
> - }
> + if (IS_ERR(chip->convert_pin))
> + return dev_err_probe(&spi_dev->dev, PTR_ERR(chip->convert_pin),
> + "Failed to request convert GPIO\n");
> if (chip->id == ID_AD7816 || chip->id == ID_AD7817) {
> chip->busy_pin = devm_gpiod_get(&spi_dev->dev, "busy",
> GPIOD_IN);
> - if (IS_ERR(chip->busy_pin)) {
> - ret = PTR_ERR(chip->busy_pin);
> - dev_err(&spi_dev->dev, "Failed to request busy GPIO: %d\n",
> - ret);
> - return ret;
> - }
> + if (IS_ERR(chip->busy_pin))
> + return dev_err_probe(&spi_dev->dev, PTR_ERR(chip->busy_pin),
> + "Failed to request busy GPIO\n");
> }

--
With Best Regards,
Andy Shevchenko