Re: [PATCH] iio: imu: bmi323: check i2c_transfer() return value
From: Joshua Crofts
Date: Thu Nov 19 2026 - 04:28:00 EST
On 19-Nov-26 8:08, Siqi Chen wrote:
> drivers/iio/imu/bmi323/bmi323_i2c.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/imu/bmi323/bmi323_i2c.c b/drivers/iio/imu/bmi323/bmi323_i2c.c
> index e025c88c30b4..18f05f119961 100644
> --- a/drivers/iio/imu/bmi323/bmi323_i2c.c
> +++ b/drivers/iio/imu/bmi323/bmi323_i2c.c
> @@ -40,8 +40,8 @@ static int bmi323_regmap_i2c_read(void *context, const void *reg_buf,
> msgs[1].flags = priv->i2c->flags | I2C_M_RD;
>
> ret = i2c_transfer(priv->i2c->adapter, msgs, ARRAY_SIZE(msgs));
> - if (ret < 0)
> - return -EIO;
> + if (ret != ARRAY_SIZE(msgs))
> + return ret < 0 ? ret : -EIO;
Better to do
if (ret < 0)
return ret;
if (ret != ARRAY_SIZE(msgs))
return -EIO;
It improves readability.
--
Kind regards,
Joshua Crofts