Re: [PATCH net-next v6 1/4] net: qrtr: Allow the host QRTR to assign a unique node id
From: Paolo Abeni
Date: Thu Nov 19 2026 - 04:35:51 EST
On 11/16/26 01:44, netdev-bot+sashiko@xxxxxxxxxx wrote:
Thank you for your contribution! Sashiko AI review found 5 potential
issue(s) to consider.
Critical: 0 · High: 0 · Medium: 2 · Low: 3
If you believe none of the issues are legitimate, please reply to each
issue of Medium severity or higher and explain why the AI is wrong.
If any of them are legitimate and you plan to respin, please let patchwork
know by including "pw-bot: cr" as a separate line at the end of your reply
(one such reply per series is enough).
- [Medium] A failed node-id insert now drops the packet, where the old
code still delivered it, and a dropped HELLO is never recovered.
- [Medium] In AUTO mode, nid and ep_nid can end up different, which the
commit message says cannot happen, and the rewrite logic then…
The first concern above looks relevant, and the 2nd deserves at least an
explicit answer.
In general you need to address (either debate or fix) every AI comment with
prio >= Mid.
Next patch as more of such comments.
/P