Re: [PATCH v2] iio: light: bh1745: fix 16-bit register accesses
From: Andy Shevchenko
Date: Thu Nov 19 2026 - 04:47:07 EST
On Wed, Nov 18, 2026 at 04:17:00PM +0200, Matti Vaittinen wrote:
> On 18/11/2026 13:42, Andy Shevchenko wrote:
> > On Wed, Nov 18, 2026 at 12:31:59PM +0200, Matti Vaittinen wrote:
> > > On 17/11/2026 16:21, Andy Shevchenko wrote:
> > > > + Cc: Matti (even he is not listed as maintainer) for possible another pair of
> > > > eyes and/or having an answer why this was missed at the time of the driver
> > > > submission (from my perspective this patch is correct).
> > >
> > > Thanks for the heads-up Andy. Unfortunately, I have never worked with this
> > > IC, and I don't think we have it in the ROHM Finland office (but I'll check
> > > this just in case. It'd be nice to have this covered in my test setup).
> > >
> > > What comes to missing this in reviews... Well, I suppose the reviewers are
> > > just humans, or if they're not, then they might have concentrated on other
> > > important things, like styling, instead of the real functionality.
> > >
> > > On my own behalf, I was away for 1.5 months when the series was applied, and
> > > I only looked at the GTS-helpers usage when I did my shallow and badly
> > > belated review. (Furthermore, I am 100% human, so I might have just missed
> > > this even if I had all the time in the world to do the review).
> >
> > Yeah, I don't know how ROHM is big, but in other companies usually there is
> > an internal mailing list is set for reviews. Maybe that helps?
>
> I took a look to the Wikipedia. ROHM isn't that big. 2017 it has been around
> 21k
> people, and I have a feeling (no facts) that size is still about the same.
>
> List might help, if we had more than 1 upstream Linux developers... :)
I see. Let's survive with the current tools!
> (I actually did request a list when I started at ROHM - and we had something
> for a couple of years. Unfortunately, I was the only one ever using that.
> After a company IT-change accidentally killed the list I never requested a
> new one. Still, even when we had the list, the bd1745 patches wouldn't
> probably have emerged to it. The get_maintainers.pl folks use to get
> relevant reviewers, wouldn't have known to add that list for a new driver
> with no 'rohm' -prefix.)
--
With Best Regards,
Andy Shevchenko