Re: [PATCH v3 02/10] drm/panthor: Rename neural accelerator feature macro to NX
From: Liviu Dudau
Date: Thu Nov 19 2026 - 04:48:54 EST
On Wed, Nov 18, 2026 at 05:53:18PM +0000, Karunika Choo wrote:
> Rename GPU_FEATURES_NEURAL_ENGINE to GPU_FEATURES_NX.
> Update the panthor_hw helper to use the new name.
>
> Signed-off-by: Karunika Choo <karunika.choo@xxxxxxx>
Reviewed-by: Liviu Dudau <liviu.dudau@xxxxxxx>
Best regards,
Liviu
> ---
> drivers/gpu/drm/panthor/panthor_gpu_regs.h | 2 +-
> drivers/gpu/drm/panthor/panthor_hw.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/panthor/panthor_gpu_regs.h b/drivers/gpu/drm/panthor/panthor_gpu_regs.h
> index 5340966caef37..c7581b6d4c5be 100644
> --- a/drivers/gpu/drm/panthor/panthor_gpu_regs.h
> +++ b/drivers/gpu/drm/panthor/panthor_gpu_regs.h
> @@ -67,7 +67,7 @@
>
> #define GPU_FEATURES 0x60
> #define GPU_FEATURES_RAY_INTERSECTION BIT(2)
> -#define GPU_FEATURES_NEURAL_ENGINE BIT(4)
> +#define GPU_FEATURES_NX BIT(4)
> #define GPU_FEATURES_RAY_TRAVERSAL BIT(5)
>
> #define GPU_TIMESTAMP_OFFSET 0x88
> diff --git a/drivers/gpu/drm/panthor/panthor_hw.h b/drivers/gpu/drm/panthor/panthor_hw.h
> index eeca936f44bae..f770dc40e6216 100644
> --- a/drivers/gpu/drm/panthor/panthor_hw.h
> +++ b/drivers/gpu/drm/panthor/panthor_hw.h
> @@ -64,7 +64,7 @@ static inline bool panthor_hw_has_pwr_ctrl(struct panthor_device *ptdev)
> static inline bool panthor_hw_has_neural(struct panthor_device *ptdev)
> {
> return (GPU_ARCH_MAJOR(ptdev->gpu_info.gpu_id) >= 14 &&
> - ptdev->gpu_info.gpu_features & GPU_FEATURES_NEURAL_ENGINE);
> + ptdev->gpu_info.gpu_features & GPU_FEATURES_NX);
> }
>
> #endif /* __PANTHOR_HW_H__ */
> --
> 2.43.0
>
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯