Re: [PATCH net-next v5 2/6] dt-bindings: net: xlnx,xxv-ethernet: Add Xilinx XXV 10G/25G Ethernet
From: Gupta, Suraj
Date: Thu Nov 19 2026 - 04:52:52 EST
Hi Rob,
On 11/18/2026 9:58 PM, Rob Herring wrote:
On Sat, Nov 14, 2026 at 11:59:43PM +0530, Suraj Gupta wrote:
The XXV Ethernet IP integrates a 10G/25G Ethernet MAC with an in-core
PCS/PMA driving a high-speed serial transceiver. Its payload is moved by
an external AXI DMA (or multichannel DMA) controller referenced through
the dmas/dma-names properties. Document the IP in a dedicated schema
file.
Add the "xlnx,xxv-ethernet-1.0" compatible with the 10gbase-r and
25gbase-r phy-modes, the rx_core/drp/s_axi clocks and the AXI DMA
channel properties. The GT transceiver reference clock is described as
an optional fourth "ref" clock, for boards where it is supplied by a
Linux-managed clock provider rather than a fixed oscillator.
Add "xlnx,has-statistics-counters" as well. The statistics counters are
an optional part of the IP, selected by the "Include Statistics Counters"
build option (PG210), and unlike the 1G MAC the subsystem has no ability
register that reports whether they were included, so the devicetree has
to describe it.
Require "xlnx,rxmem". The driver reads it unconditionally at probe time
and fails if it is absent, and the value is what bounds the largest frame
the device accepts, both when validating a new MTU and when deciding
whether jumbo frames can be enabled.
Disallow phy-handle, its deprecated phy and phy-device spellings, and
pcs-handle. All are inherited from ethernet-controller.yaml, so
unevaluatedProperties does not reject them, but the subsystem has no MDIO
bus master and its PCS is in-core, so neither an external PHY nor an
external PCS can be attached. Constrain managed to in-band-status for the
same reason; it stays optional, as the link is always managed in-band.
Signed-off-by: Suraj Gupta <suraj.gupta2@xxxxxxx>
---
.../bindings/net/xlnx,xxv-ethernet.yaml | 146 ++++++++++++++++++
MAINTAINERS | 1 +
2 files changed, 147 insertions(+)
create mode 100644 Documentation/devicetree/bindings/net/xlnx,xxv-ethernet.yaml
diff --git a/Documentation/devicetree/bindings/net/xlnx,xxv-ethernet.yaml b/Documentation/devicetree/bindings/net/xlnx,xxv-ethernet.yaml
new file mode 100644
index 000000000000..caf582c72a8d
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/xlnx,xxv-ethernet.yaml
@@ -0,0 +1,146 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/xlnx,xxv-ethernet.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Xilinx XXV 10G/25G Ethernet Subsystem
+
+maintainers:
+ - Radhey Shyam Pandey <radhey.shyam.pandey@xxxxxxx>
+ - Suraj Gupta <suraj.gupta2@xxxxxxx>
+
+description:
+ The Xilinx XXV Ethernet Subsystem implements a 10G/25G Ethernet MAC with an
+ in-core PCS/PMA driving a high-speed serial transceiver. It supports the
+ 10GBASE-R and 25GBASE-R line rates, with 25G operation following the 25G
+ Ethernet Consortium specification. Because the PCS/PMA is integrated into
+ the IP, the subsystem has no MDIO bus master and is not managed through an
+ external MDIO PHY; link state is read from the MAC's own status registers.
+ As there is no PHY to manage, the link is always managed in-band.
+ Any SFP module management (e.g. I2C) is handled by separate IP outside this
+ binding. Its payload is moved by an external AXI DMA (or multichannel DMA)
+ controller referenced through the "dmas" property.
+
+properties:
+ compatible:
+ const: xlnx,xxv-ethernet-1.0
I hope you based 1.0 on something? Looks made up to me.
From here[1], looks like you are missing some versions:
The offset of user configuration registers in the IP was updated (and
removed in case of USER_REG_1) which breaks backward compatibility of
any custom user config application code with newer versions of the IP.
Please make sure to use the correct offset as per the IP version as
specific below and ignore "XXE_USR0_OFFSET". Please note that this has
NO impact on the example as this definition is not used.
Upto IP Version 2.2 https://docs.xilinx.com/v/u/2.2-English/pg210-25g-ethernet, USER_REG_0 is at offset 0x184 and USER_REG_1 is at offset 0x188
IP Version 2.3 and above https://docs.xilinx.com/v/u/2.3-English/pg210-25g-ethernet, USER_REG_0 is at offset 0x134 and USER_REG_1 is removed
Rob
[1] https://xilinx-wiki.atlassian.net/wiki/spaces/A/pages/18842542/Baremetal+XXV+Ethernet+driver
1.0 is the initial release of this IP: PG210 v1.0, 2015-09-30, "Initial release" [1]. The compatible names that version. Newer cores are handled from the revision register (CONFIGURATION_REVISION_REG, 0x24), read into lp->xxv_ip_version. Today that gates only the GT status registers, which PG210 adds in v3.2.
The same v3.2 changelog adds bit 0 of STAT_RX_STATUS_REG1 (0x404). v5 reads that bit unconditionally for the link state, so I will gate it on v3.2 and later in v6.
The driver does not use USER_REG_0, so the v2.3 move (0x184 to 0x134) and the removal of USER_REG_1 do not affect it. The wiki pointed above describes the baremetal XXV driver.
[1] https://docs.amd.com/r/en-US/pg210-25g-ethernet/Revision-History
Regards,
Suraj