Re: [PATCH v2] fs: sync: fix overflow check in sync_file_range()
From: Jan Kara
Date: Thu Nov 19 2026 - 05:05:13 EST
On Thu 19-11-26 11:08:27, mdshahid03@xxxxxxxxx wrote:
> From: Mohammad Shahid <mdshahid03@xxxxxxxxx>
>
> Use check_add_overflow() to detect overflow when calculating
> the end byte of the requested range.
>
> Reject negative offsets and lengths before performing the
> addition.
>
> Signed-off-by: Mohammad Shahid <mdshahid03@xxxxxxxxx>
Looks good. Feel free to add:
Reviewed-by: Jan Kara <jack@xxxxxxx>
Honza
> ---
> fs/sync.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/fs/sync.c b/fs/sync.c
> index 4a84dd837b86..a1ef2b619cfc 100644
> --- a/fs/sync.c
> +++ b/fs/sync.c
> @@ -10,6 +10,7 @@
> #include <linux/slab.h>
> #include <linux/export.h>
> #include <linux/namei.h>
> +#include <linux/overflow.h>
> #include <linux/sched.h>
> #include <linux/writeback.h>
> #include <linux/syscalls.h>
> @@ -233,13 +234,10 @@ int sync_file_range(struct file *file, loff_t offset, loff_t nbytes,
> if (flags & ~VALID_FLAGS)
> goto out;
>
> - endbyte = offset + nbytes;
> -
> - if ((s64)offset < 0)
> - goto out;
> - if ((s64)endbyte < 0)
> + if (offset < 0 || nbytes < 0)
> goto out;
> - if (endbyte < offset)
> +
> + if (check_add_overflow(offset, nbytes, &endbyte))
> goto out;
>
> if (sizeof(pgoff_t) == 4) {
> --
> 2.43.0
>
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR