[PATCH 1/2] drm/rockchip: vop2: Reject double clocked modes on RK3588

From: Arun Iyengar via B4 Relay

Date: Thu Nov 19 2026 - 05:06:13 EST


From: Arun Iyengar <aiyengar1990@xxxxxxxxx>

Pixel repeated modes (DRM_MODE_FLAG_DBLCLK, e.g. 720(1440)x480i) need
each pixel sent twice. RK3588 cannot do that: DSP_CTRL.CORE_DCLK_DIV is
reserved, dclk_core already runs at dclk/4 and the HDMI QP TX has no
pixel repetition. The doubled dclk then sends a timing that does not
match the VIC. Reject such modes on RK3588.

Fixes: 5a028e8f062f ("drm/rockchip: vop2: Add support for rk3588")
Signed-off-by: Arun Iyengar <aiyengar1990@xxxxxxxxx>
---
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
index 76d151b8bc52..1458d8ae79d6 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
@@ -1581,6 +1581,11 @@ static enum drm_mode_status vop2_crtc_mode_valid(struct drm_crtc *crtc,
if (mode->hdisplay > vp->data->max_output.width)
return MODE_BAD_HVALUE;

+ /* RK3588 cannot repeat pixels: no CORE_DCLK_DIV, dclk_core at dclk/4 */
+ if (mode->flags & DRM_MODE_FLAG_DBLCLK &&
+ vp->vop2->version == VOP_VERSION_RK3588)
+ return MODE_H_ILLEGAL;
+
return MODE_OK;
}


--
2.55.0