Re: [PATCH v12 4/6] clk: ambarella: add CV75 RCT clock controller

From: Andy Shevchenko

Date: Thu Nov 19 2026 - 05:22:46 EST


On Thu, Nov 19, 2026 at 06:13:22PM +0800, Long Zhao via B4 Relay wrote:
>
> Add a table-driven CCF driver for the CV75 root clock tree. Register
> the core PLL, AHB/APB fixed factors and UART0 composite clock, with
> osc supplied via clk_parent_data.

...

> +config CLK_AMBARELLA_CV75
> + bool "Ambarella CV75 RCT clock controller"
> + depends on ARCH_AMBARELLA || COMPILE_TEST
> + default ARCH_AMBARELLA
> + help
> + Say Y here to enable the Ambarella CV75 RCT clock controller.

Tell a bit more when it's required. For example, if it's necessary to boot the
system or if it's just a bunch of some peripheral clocks that don't affect any
basic stuff. Note, checkpatch complains if the help text is less than 3 lines.


...

> +static const struct cv75_pll cv75_plls[] = {
> + CV75_PLL(CV75_GCLK_CORE, "core", 0x000, 0x004, 0x100,
> + 0, &cv75_ccu.core),
> + CV75_PLL(-1, "pll_enet", 0x520, 0x524, 0x528,
> + 0, &cv75_ccu.enet),
> + CV75_PLL(-1, "pll_sd", 0x4ac, 0x4b0, 0x4b4,
> + 0, &cv75_ccu.sd),
> +};

Now it can occupy less LoC.

static const struct cv75_pll cv75_plls[] = {
CV75_PLL(CV75_GCLK_CORE, "core", 0x000, 0x004, 0x100, 0, &cv75_ccu.core),
CV75_PLL(-1, "pll_enet", 0x520, 0x524, 0x528, 0, &cv75_ccu.enet),
CV75_PLL(-1, "pll_sd", 0x4ac, 0x4b0, 0x4b4, 0, &cv75_ccu.sd),
};

--
With Best Regards,
Andy Shevchenko