Re: [PATCH v9] PCI: exynos: Handle PCIe PHY initialization errors
From: Manivannan Sadhasivam
Date: Thu Nov 19 2026 - 05:53:11 EST
On 2026-10-31 09:49 +0000, Sreeraj S Kurup wrote:
> Check the return values of phy_init() and phy_power_on() to avoid
> continuing PCIe host initialization when PHY setup fails.
>
> Track PHY initialization, PHY power, and regulator enable state
> across probe, remove, suspend, and resume to ensure cleanup is
> performed only when appropriate and to prevent unbalanced
> reference counts.
>
> Assert core reset on probe failure after PHY initialization has
> been reached, and handle cleanup errors during teardown and
> suspend.
>
> Also check the return value of exynos_pcie_host_init() during
> resume and abort the resume sequence if PHY initialization fails.
>
> Signed-off-by: Sreeraj S Kurup <sreekuttan2156239@xxxxxxxxx>
NACK.
First of all, you are sending each version as a reply to the previous one, which
is not recommended.
Second, you just ended up fixing all Sashiko reported issues without cross
checking whether they are really valid or not and the patch just became noise
now. For instance, this phy_init() can never fail on the only platform supported
by this driver and there is no PHY power_on() callback (idk why phy_power_on()
exists in the first place). So all the error handling you added for these APIs
are dead code.
So please, do not blindly fix all the issues reported by Sashiko. Do your own
homework!
- Mani