[PATCH v3 3/3] dm thin: free thins with kfree_rcu() instead of waiting in thin_dtr()
From: Qiliang Yuan
Date: Thu Nov 19 2026 - 06:06:01 EST
thin_dtr() takes the thin off pool->active_thins once its last
reference is dropped and then waits for a grace period, so that
requeue_bios() and error_retry_list_with_code(), which walk the list
under rcu_read_lock(), are done with the thin before it is freed.
Removing a thin device thus waits for a full grace period in thin_dtr(),
although those readers only need the memory of the thin to stay around.
Free the thin with kfree_rcu() instead of waiting for the grace period.
Removing 100 thin devices of an idle pool with dmsetup remove takes per
device (mean of five rounds, min-max of the rounds in parentheses). The
queue freeze in del_gendisk() waits for a grace period of its own, which
the one in thin_dtr() used to overlap, so only part of it is saved:
before (ms) after (ms) change
17.2 (17.0-17.4) 13.7 (13.2-14.4) -20%
Signed-off-by: Qiliang Yuan <qiliang.yuan@xxxxxxxxx>
---
drivers/md/dm-thin.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/md/dm-thin.c b/drivers/md/dm-thin.c
index 62ef96bf08cb3..e695fc356c4dc 100644
--- a/drivers/md/dm-thin.c
+++ b/drivers/md/dm-thin.c
@@ -360,6 +360,7 @@ struct thin_c {
*/
refcount_t refcount;
struct completion can_destroy;
+ struct rcu_head rcu;
/*
* Keeps new active_thin walkers from grabbing the table while
* thin_dtr() is waiting for the existing holders to finish.
@@ -4169,7 +4170,6 @@ static void thin_dtr(struct dm_target *ti)
spin_lock_irq(&tc->pool->lock);
list_del_rcu(&tc->list);
spin_unlock_irq(&tc->pool->lock);
- synchronize_rcu();
mutex_lock(&dm_thin_pool_table.mutex);
@@ -4178,7 +4178,8 @@ static void thin_dtr(struct dm_target *ti)
dm_put_device(ti, tc->pool_dev);
if (tc->origin_dev)
dm_put_device(ti, tc->origin_dev);
- kfree(tc);
+ /* Let RCU readers of active_thins finish with tc before freeing it */
+ kfree_rcu(tc, rcu);
mutex_unlock(&dm_thin_pool_table.mutex);
}
--
2.43.0