Re: [PATCH v2] docs: submitting-patches: ask bug fixes for their user-visible impact
From: Leon Romanovsky
Date: Thu Nov 19 2026 - 06:19:23 EST
On Thu, Nov 19, 2026 at 11:13:57AM +0100, Krzysztof Kozlowski wrote:
> On 17/11/2026 10:27, Leon Romanovsky wrote:
> > On Mon, Nov 16, 2026 at 03:05:15PM -0500, Sasha Levin wrote:
> >> "Describe your changes" already asks for the user-visible impact of a
> >> change, but changelogs for fixes still tend to say what the code does,
> >> why that's wrong and what the patch changes, and stop there. Whoever
> >> has to decide if the fix needs backporting is left to work out what
> >> the bug does to a running system.
> >>
> >> Say what that means for a bug fix, in two parts. For users who aren't
> >> looking for the bug: what a normal workload is likely to run into, and
> >> separately the worst case and what it takes to get there. For someone
> >> triggering it on purpose: whether an unprivileged user could do it and
> >> what that would take, since a race that no real workload loses can
> >> still be won by a program written to win it. Give the paragraph a
> >> label so people can be pointed at it.
> >>
> >> Coding assistants are told to commit a fix with a message that
> >> describes the problem and the solution. Add the user-visible impact to
> >> that list and point them at the section.
> >>
> >> Suggested-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> >> Link: https://lore.kernel.org/r/20261111171055.527b4bf3da705367bc78a64c@xxxxxxxxxxxxxxxxxxxx
> >> Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
> >> Acked-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> >> Reviewed-by: Willy Tarreau <w@xxxxxx>
> >> ---
> >> Changes since v1:
> >> - Split the bug-fix paragraph into users who aren't looking for the bug
> >> and someone triggering it on purpose (Andrew, Willy).
> >>
> >> v1: https://lore.kernel.org/r/20261116191436.188098-1-sashal@xxxxxxxxxx
> >>
> >> Documentation/process/coding-assistants.rst | 6 +++--
> >> Documentation/process/submitting-patches.rst | 23 ++++++++++++++++++++
> >> 2 files changed, 27 insertions(+), 2 deletions(-)
> >
> > Sasha,
> >
> > Since you're already making changes in that area, could you add a sentence
> > asking reporters to provide the full dmesg stack trace?
>
> If so, then trimmed. We do not need all addresses and registers and the
> [time markers], but rather the calltrace from decode_stacktrace.sh.
Regarding time markers, I agree. However, addresses are an important part of
debugging information. These bugs are rare, but addresses are still useful for
identifying incorrect pointer arithmetic or pointer assignments.
> That's often review feedback, btw, people just paste huge bunch of dmesg
> without thinking what is useful there.
It’s still better than AI-generated prose peppered with short, two- or
three-line stack traces intended to trick me into merging a patch. I’d
rather trim the description myself than rely on random submitters to
provide exactly the right amount of information—no more, no less.
Thanks