Re: [PATCH v2 1/2] arm64: dts: allwinner: orangepi-zero2: Reference the SPI NOR by label
From: Andre Przywara
Date: Thu Nov 19 2026 - 06:19:35 EST
Hi Arun,
thanks for the changes and the respin!
On 11/19/26 06:29, Arun Iyengar via B4 Relay wrote:
From: Arun Iyengar <aiyengar1990@xxxxxxxxx>
Andre Przywara suggested labelling the flash node, so the Zero2 sets its
supply through the label instead of nesting flash@0 in &spi0.
Suggested-by: Andre Przywara <andre.przywara@xxxxxxx>
Signed-off-by: Arun Iyengar <aiyengar1990@xxxxxxxxx>
---
arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero.dtsi | 2 +-
arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero2.dts | 10 ++++------
2 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero.dtsi
index 0d3e761f6466..646d92e0f724 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero.dtsi
@@ -104,7 +104,7 @@ &spi0 {
pinctrl-names = "default";
pinctrl-0 = <&spi0_pins>, <&spi0_cs0_pin>;
- flash@0 {
+ flash: flash@0 {
I feel like "spi_flash" would be a better, more specific label to use, "flash" is a bit generic.
#address-cells = <1>;
#size-cells = <1>;
compatible = "jedec,spi-nor";
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero2.dts
index 90c25e12e189..59bbb09bcdbf 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero2.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero2.dts
@@ -24,6 +24,10 @@ &emac0 {
phy-supply = <®_dcdce>;
};
+&flash {
+ vcc-supply = <®_aldo1>;
+};
+
Could you do me a favour and add the OrangePi Zero3 regulator as well, to sun50i-h618-orangepi-zero3.dts? It's also reg_aldo1, although that's a different PMIC, so actually a different regulator, and so should stay in the board specific .dts (even though the lines look the same).
That saves me from sending a follow-up patch with a dependency.
Otherwise the patch looks alright!
Thanks,
Andre.
&gpu {
mali-supply = <®_dcdcc>;
};
@@ -147,9 +151,3 @@ &pio {
vcc-ph-supply = <®_aldo1>;
vcc-pi-supply = <®_aldo1>;
};
-
-&spi0 {
- flash@0 {
- vcc-supply = <®_aldo1>;
- };
-};