[PATCH v3 0/4] media: iris: Fix issues in the driver unbind path
From: Vishnu Reddy
Date: Thu Nov 19 2026 - 06:46:10 EST
The driver unbind can be triggered through sysfs while a client has a
video session running. The devm resources are freed when the unbind
completes. That leads to use after free for the running sessions.
The core and its device are now kept allocated until the last file
descriptor is closed. New sessions are stopped as soon as the removal
starts.
The system error work was only cancelled during the removal. An
interrupt could still arrive afterwards and queue the work again. The
work is now disabled.
The runtime PM usage count was dropped twice when a resume failed. This
happens for a command written after runtime PM is disabled. The count
underflowed. The reference is no longer dropped a second time.
Signed-off-by: Vishnu Reddy <busanna.reddy@xxxxxxxxxxxxxxxx>
---
Changes in v3:
- Ensured that runtime PM references are dropped before driver removal.
- Dropped the unnecessary interrupt freeing change.
- Link to v2: https://patch.msgid.link/20261110-iris-handle-unbind-v2-0-86d5f6f1dea8@xxxxxxxxxxxxxxxx
Changes in v2:
- Updated the commit description of patch 3 (Bryan)
- Split the interrupt freeing into a separate patch (Bryan)
- Added a new patch to wake up clients blocked on open sessions at removal.
- Link to v1: https://lore.kernel.org/r/20261017-iris-handle-unbind-v1-0-7809148eb90f@xxxxxxxxxxxxxxxx
---
Vishnu Reddy (4):
media: iris: Fix runtime PM reference imbalance on failed resume
media: iris: Disable the system error work on removal
media: iris: Fix use-after-free on unbind with open sessions
media: iris: Wake up blocked clients when the driver is removed
drivers/media/platform/qcom/iris/iris_core.c | 5 ++
drivers/media/platform/qcom/iris/iris_core.h | 4 ++
drivers/media/platform/qcom/iris/iris_hfi_queue.c | 20 ++++++-
drivers/media/platform/qcom/iris/iris_instance.h | 2 +
drivers/media/platform/qcom/iris/iris_power.c | 24 ++++++++-
drivers/media/platform/qcom/iris/iris_probe.c | 66 +++++++++++++++++++----
drivers/media/platform/qcom/iris/iris_vidc.c | 20 ++++++-
7 files changed, 127 insertions(+), 14 deletions(-)
---
base-commit: e8017d29067fd1310a65c3494ce1a1b492adbac6
change-id: 20261013-iris-handle-unbind-fe09689e6696
Best regards,
--
Vishnu Reddy <busanna.reddy@xxxxxxxxxxxxxxxx>