Re: [PATCH v3 03/14] irqchip/gic-v5: Serialise IRS synchronisation requests
From: Fuad Tabba
Date: Thu Nov 19 2026 - 06:54:08 EST
Hi Sascha,
On Wed, 18 Nov 2026 17:35:32 +0000, Sascha Bischoff
<sascha.bischoff@xxxxxxx> wrote:
> IRS_SYNCR writes are ignored while IRS_SYNC_STATUSR.IDLE is clear.
> Concurrent calls to gicv5_irs_syncr() can overlap, causing a request
> to be dropped. A caller can then observe the earlier request
> completing and assume that its own events have been processed.
>
> gicv5_irs_syncr() may need to be called in atomic context. Serialise
> the request and completion poll with a raw spinlock, and use atomic
> polling.
>
> Fixes: 57d72196dfc8 ("irqchip/gic-v5: Add GICv5 ITS support")
> Signed-off-by: Sascha Bischoff <sascha.bischoff@xxxxxxx>
> Acked-by: Lorenzo Pieralisi <lpieralisi@xxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx
I don't think two calls can overlap in the host driver today. The only
caller is gicv5_its_irq_domain_free(), and since the LPI domain is the
parent of every ITS domain, irq_domain_free_irqs() holds the LPI
domain's mutex around that call. Do we need the Fixes: and Cc: stable
tags then?
That said:
Reviewed-by: Fuad Tabba <fuad.tabba@xxxxxxxxx>
Cheers,
/fuad