Re: [PATCH] usb: usbtmc: reject a short READ_STATUS_BYTE control transfer
From: Greg Kroah-Hartman
Date: Thu Nov 19 2026 - 08:13:36 EST
On Thu, Nov 19, 2026 at 05:39:59PM +0900, Hyunjung Ko wrote:
> usbtmc_get_stb() asks the device for three bytes of the READ_STATUS_BYTE
> response into a kmalloc()'d buffer and only checks that usb_control_msg()
> did not fail:
>
> buffer = kmalloc(8, GFP_KERNEL);
> ...
> rv = usb_control_msg(..., buffer, 0x03, USB_CTRL_GET_TIMEOUT);
> if (rv < 0)
> goto exit;
>
> usb_control_msg() returns the number of bytes actually transferred,
> which a device is free to make shorter than the three that were
> requested. When the interface has no interrupt-in endpoint the status
> byte is then taken straight from the third byte:
>
> *stb = buffer[2];
>
> and the caller hands it to user space with put_user() from
> USBTMC488_IOCTL_READ_STB and USBTMC_IOCTL_GET_SRQ_STB. A device that
> answers with one or two bytes - with the first byte set to
> USBTMC_STATUS_SUCCESS so the status check passes - therefore leaks one
> byte of uninitialised kmalloc memory to user space. Both conditions are
> under the device's control, since it also decides whether to expose an
> interrupt-in endpoint.
>
> The same leak was fixed once before in this driver: usbtmc_ioctl_request()
> bounds its copy_to_user() to the number of bytes usb_control_msg() reported
> instead of the number requested. usbtmc_get_stb() cannot be fixed that way
> because it reads a fixed offset, so reject the transfer unless all three
> bytes arrived, matching what usbtmc488_ioctl_simple() already does for its
> own one-byte request.
>
> The check is not limited to the branch that reads buffer[2]: buffer[0] is
> consumed on both paths, so a short response leaves the status check itself
> reading uninitialised memory. USBTMC-USB488 4.3.1 requires the three-byte
> response, so a device that sends fewer is not conforming either way.
>
> Signed-off-by: Hyunjung Ko <hj351016@xxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx
This is a "fun" one in that LLMs keep tripping over it, and they
generate a patch that is usually wrong, like this one.
Be very careful here, and test your changes with a real device please.
thanks,
greg k-h