Re: [PATCH 1/3] media: qcom: iris: improve probe error reporting
From: bod
Date: Thu Nov 19 2026 - 08:15:22 EST
On 2026-11-06 15:31 +0000, Dipayaan Roy wrote:
> The Iris probe path returned errors from resource initialization and
> device registration without identifying the operation that failed. This
> made failures difficult to diagnose, especially when several resources
> were acquired during probe.
>
> Use dev_err_probe() at probe and resource initialization failure paths to
> report useful context while preserving deferred-probe handling. Also
> validate the platform match data before it is dereferenced.
>
> Successful probe behavior and existing cleanup paths remain unchanged.
>
> Signed-off-by: Dipayaan Roy <dipayaan.roy@xxxxxxxxxxxxxxxx>
> @@ -220,18 +257,18 @@ static int iris_register_video_device(struct iris_core *core, enum domain_type t
> strscpy(vdev->name, "qcom-iris-decoder", sizeof(vdev->name));
> vdev->ioctl_ops = core->iris_v4l2_ioctl_ops_dec;
> core->vdev_dec = vdev;
> - } else if (type == ENCODER) {
> + } else {
This change isn't just "fix the prints" so either drop it or separate it.
---
bod