Re: [PATCH] gpio: mpsse: reject bulk-in endpoints smaller than 3 bytes
From: khj
Date: Thu Nov 19 2026 - 08:26:08 EST
Sorry, wrong thread - that reply was meant for an unrelated usbtmc
patch. Nothing to do here, the mpsse one is fine as applied.
Hyunjung
2026년 11월 19일 (목) 오후 10:23, khj <hj351016@xxxxxxxxx>님이 작성:
>
> You're right, sorry for the noise..!
>
> buffer[2] is only read when there's no interrupt-in endpoint, so
> rejecting every short transfer would break the devices that get the
> status byte from the notification instead. Dropping the patch, I don't
> have the hardware to test a narrower fix..
>
> Hyunjung
>
> 2026년 11월 19일 (목) 오후 7:33, Bartosz Golaszewski
> <bartosz.golaszewski@xxxxxxxxxxxxxxxx>님이 작성:
> >
> >
> > On Tue, 17 Nov 2026 19:41:10 +0900, Hyunjung Ko wrote:
> > > mpsse_read() reads min(len + 2, wMaxPacketSize) bytes and then copies
> > > len_actual - 2 bytes to the caller. A device that declares a bulk-in
> > > endpoint with wMaxPacketSize 1 completes the read with len_actual 1, so
> > > the copy length becomes -1 and memcpy() runs far past the one byte
> > > buffer on the caller's stack and past bulk_in_buf:
> > >
> > > memcpy: detected buffer overflow: 18446744073709551615 byte write of buffer size 1
> > > WARNING: lib/string_helpers.c:1036 at __fortify_report+0x6e/0xc0
> > > Call Trace:
> > > __fortify_panic+0xd/0x10
> > > gpio_mpsse_get_multiple+0x767/0x780
> > > gpio_mpsse_gpio_get+0xa2/0xf0
> > > gpiod_get_raw_value_commit+0xf8/0x1f0
> > > gpiod_get_value_cansleep+0x1e/0xa0
> > > value_show+0x42/0x90
> > >
> > > [...]
> >
> > Applied, thanks!
> >
> > [1/1] gpio: mpsse: reject bulk-in endpoints smaller than 3 bytes
> > https://git.kernel.org/brgl/c/f94f85f82e042c89a1e64ed3ff1d591a2bccfa7b
> >
> > Best regards,
> > --
> > Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxxxxxxxx>