Re: [PATCH v2 1/2] dt-bindings: media: qcom,glymur-camss: Drop port@3

From: Nihal Kumar Gupta

Date: Thu Nov 19 2026 - 08:34:39 EST




On 19-11-2026 17:36, Krzysztof Kozlowski wrote:
>> How would you prefer this ABI issue to be handled, or should I
>> send the next version incorporating Loic's comments?
> Commit msg should be clear that ABI is changed, whether that ABI was
> ever working or even correct/possible to work in the first place. You do
> not answer my question really, because if description was not correct
> but everything was working fine, then clearly IT WAS correct to some level.

Yes, you are right. The old ABI was functional with the driver data at that
time, even though it used the X1E80100 CSIPHY resource index instead of a
Glymur-specific port mapping.

Old mapping:
port@0 -> X1E80100 csiphy_res[0] -> CSIPHY0
port@1 -> X1E80100 csiphy_res[1] -> CSIPHY1
port@2 -> X1E80100 csiphy_res[2] -> CSIPHY2, not present on Glymur
port@3 -> X1E80100 csiphy_res[3] -> CSIPHY4

So port@3 was functional before.

Now, Glymur is using linear graph ports instead of reusing X1E80100:
port@0 -> csiphy_res[0] -> CSIPHY0
port@1 -> csiphy_res[1] -> CSIPHY1
port@2 -> csiphy_res[2] -> CSIPHY4

I will make this ABI change clear in the commit message.
--
Regards,
Nihal Kumar Gupta