Re: [PATCH v3 14/14] irqchip/gic-v5: Invalidate the L1 DTE when allocating an L2 device table

From: Lorenzo Pieralisi

Date: Thu Nov 19 2026 - 08:36:56 EST


On Thu, Nov 19, 2026 at 12:32:56PM +0000, Fuad Tabba wrote:
> On Thu, 19 Nov 2026 10:13:31 +0000, Lorenzo Pieralisi
> <lpieralisi@xxxxxxxxxx> wrote:
> [...]
> >> diff --git a/drivers/irqchip/irq-gic-v5-its.c b/drivers/irqchip/irq-gic-v5-its.c
> [...]
> >> +static int gicv5_its_device_l1_cache_inv(struct gicv5_its_chip_data *its,
> >> + u32 device_id)
> >> +{
> >> + return __gicv5_its_device_cache_inv(its, device_id, 0, true);
> >
> > I would highlight why event_id_bits is set to 0 (actually it is irrelevant,
> > let's explicitly say so).
>
> With L1 set, the effective value of ITS_INV_DEVICER.EVENTID_BITS is
> the maximum in ITS_IDR2.EVENTID_BITS, whatever was written.

Yep, that's what I meant, I don't want "0" to look like we are
trying to optimize anything in there because there isn't anything
to optimize; a comment would do.

Thanks,
Lorenzo

> nit: this helper has a single caller, so could you call
> __gicv5_its_device_cache_inv() directly from
> gicv5_its_alloc_l2_devtab() and put Lorenzo's comment on that call?
>
> Reviewed-by: Fuad Tabba <fuad.tabba@xxxxxxxxx>
>
> Cheers,
> /fuad