[PATCH v2 3/3] i2c: imx: return -ENXIO at once when a DMA write is not acknowledged

From: Mehmet Fide

Date: Thu Nov 19 2026 - 08:43:27 EST


From: Mehmet Fide <mehmet.fide@xxxxxxxxxxxxxxxxxx>

When a byte of a DMA write is not acknowledged the controller raises its
interrupt and no DMA request, so i2c_imx_dma_write() blocks for
DMA_TIMEOUT (1 s) and returns -ETIMEDOUT, where the interrupt driven
write returns -ENXIO.

Let the interrupt handler end the wait when it sees a missing
acknowledge during a DMA write, and return -ENXIO. The last byte the DMA
writes is still on the bus when its completion arrives: look at its
acknowledge once the byte is out, before the final byte is sent.

Fixes: ce1a78840ff7 ("i2c: imx: add DMA support for freescale i2c driver")
Cc: stable@xxxxxxxxxxxxxxx
Signed-off-by: Mehmet Fide <mehmet.fide@xxxxxxxxxxxxxxxxxx>
---
drivers/i2c/busses/i2c-imx.c | 9 +++++++++
1 file changed, 9 insertions(+)

diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
index fbfabceb29ac..06b082c677a3 100644
--- a/drivers/i2c/busses/i2c-imx.c
+++ b/drivers/i2c/busses/i2c-imx.c
@@ -480,6 +480,9 @@ static int i2c_imx_dma_wait(struct imx_i2c_struct *i2c_imx)
if (!wait_for_completion_timeout(&dma->cmd_complete,
msecs_to_jiffies(DMA_TIMEOUT)))
result = -ETIMEDOUT;
+ else if (dma->dma_transfer_dir == DMA_MEM_TO_DEV &&
+ (i2c_imx->i2csr & I2SR_RXAK))
+ result = -ENXIO;

if (result)
dmaengine_terminate_sync(dma->chan_using);
@@ -1123,6 +1126,9 @@ static irqreturn_t i2c_imx_master_isr(struct imx_i2c_struct *i2c_imx, unsigned i
switch (i2c_imx->state) {
case IMX_I2C_STATE_DMA:
i2c_imx->i2csr = status;
+ if ((status & I2SR_RXAK) &&
+ i2c_imx->dma->dma_transfer_dir == DMA_MEM_TO_DEV)
+ complete(&i2c_imx->dma->cmd_complete);
wake_up(&i2c_imx->queue);
break;

@@ -1248,6 +1254,9 @@ static int i2c_imx_dma_write(struct imx_i2c_struct *i2c_imx,
schedule();
}

+ if (temp & I2SR_RXAK)
+ return -ENXIO;
+
temp = imx_i2c_read_reg(i2c_imx, IMX_I2C_I2CR);
temp &= ~I2CR_DMAEN;
imx_i2c_write_reg(temp, i2c_imx, IMX_I2C_I2CR);
--
2.56.0