Re: [PATCH v15 00/35] Introduce SCMI Telemetry support

From: Sudeep Holla

Date: Thu Nov 19 2026 - 09:15:42 EST


On Wed, Nov 18, 2026 at 06:39:16PM +0000, Cristian Marussi wrote:
> On Wed, Nov 18, 2026 at 09:32:03AM -0800, Jonathan Cameron wrote:
> > On Wed, 18 Nov 2026 09:33:44 +0000
> > Sudeep Holla <sudeep.holla@xxxxxxxxxx> wrote:
> >
> > > On Tue, Nov 17, 2026 at 05:07:09PM -0800, Jonathan Cameron wrote:
> > > > On Mon, 9 Nov 2026 09:11:46 +0000
> > > > Cristian Marussi <cristian.marussi@xxxxxxx> wrote:
> > > >
> > > > > Hi all,
> > > > >
> > > > > [TLDR Summary]
> > > > > [V15 highlights]
> > > > > - general cleanup and hardening driven by reviews
> > > > > - improved TDCF access routines to minimize lost samples under load
> > > > > - completed ABI docs
> > > > >
> > > > > [V16 TODO]
> > > > > - address any remaining V15 outstanding Sashiko/reviewers issues
> > > > >
> > > > > The upcoming SCMI v4.0 specification [0] introduces a new SCMI protocol
> > > > > dedicated to System Telemetry.
> > > >
> > > > This is one from the family of issues you find when reviewing ones own
> > > > (well LLM generated) emulation, realizing it doesn't match the spec,
> > > > and yet works.
> > > >
> > > > This works fine without the required SCMI protocol property in ACPI.
> > > > 2.2.2 of ACPI for System Control and Management Interface 1.0
> > > > Platform Design Document. 111115A 1.0
> > > >
> > > > Now, in here is an informative statement...
> > > >
> > > > Protocols not listed using a property may not be enumerate by the operating system.
> > > >
> > > > But they are...
> > > >
> > >
> > > Correct, I intentionally left that out. I do have a patch that restricts it
> > > strictly to the listed property. However, I held off on pushing it because of
> > > an issue we saw on an internal test platform.
> > >
> > > On that platform, the firmware advertised the protocol to the OSPM via the
> > > base protocol, even though it wasn't functional at all. Once they realized
> > > this, they simply dropped the entry from the ACPI SCMI device as a workaround
> > > instead of properly fixing the base protocol discovery. While understandable,
> > > relying on that workaround delays proper firmware fixes.
> > >
> > > That is why I went with the non-mandatory "may not be" wording. I am happy to
> > > merge that restriction patch if a real production platform actually needs it,
> > > but until then, leaving it open helps catch and fix broken firmware
> > > implementations 😄.
> >
> > You can't merge it safely as at a later date because chances are high
> > someone is relying on the current behavior and not presenting that
> > (currently pointless) package in ACPI for some protocol or other.
> >
> > I'm fine with a permanent decision not to check this but I don't see it
> > as a thing that can ever change (except maybe now whilst there are not
> > that many platforms out there using it!)
> >
>
> Even though the change would be at the transport layer, given that it is
> NOT impacting the Base protocol, cant we anyway quirk it later on based on FW
> vendor/version as an extrema ratio so as to support anyway older FW
> leveraging the current behaviour ? (not ideal I agree...and I have to
> double check what changes could be needed in the quirk framework..)
>

Equally good point. I am worried as Jonathan say what we many platforms
start to depend on current logic and end up skipping the ACPI property
in the firmware which can be problematic to address in the future.

Let me think about it so that we can address possible f/w bug issue as
well.

--
Regards,
Sudeep