Re: [PATCH v5 1/2] nvme-multipath: apply delayed_removal_secs changes to a pending removal

From: Nilay Shroff

Date: Thu Nov 19 2026 - 09:22:30 EST


On 11/19/26 4:37 PM, Qiliang Yuan wrote:
With delayed_removal_secs set, removing the last path of a namespace
head doesn't delete the head right away. nvme_mpath_remove_disk()
queues remove_work with the configured delay, and bios submitted in the
meantime wait on head->requeue_list in case a path comes back.

A write to delayed_removal_secs only takes effect for removals that
start later. A removal that is already pending keeps the old delay, so
clearing the attribute leaves the queued bios waiting until that delay
expires instead of failing them, and lowering or raising it doesn't
move the pending removal either.

Requeue a pending remove_work with the new delay when the attribute is
written, cancelling it first so that the module reference taken for it
carries over. Have nvme_init_ns_head() cancel the pending removal
before it drops subsys->lock rather than after, so that a write to the
attribute cannot requeue the removal once a path is back.

With delayed_removal_secs set and no path left, the attribute is
changed two seconds later and the head is removed after (mean of two
runs, min-max in parentheses):

delay (s) before (ms) after (ms) change
30 -> 0 26655 (26537-26772) 8 (8-8) -99.97%
30 -> 5 28298 (28094-28501) 5514 (5510-5517) -81%
10 -> 30 8112 (8106-8117) 30376 (30106-30646) +274%

A direct read queued before the 30 -> 0 write fails after:

before (ms) after (ms) change
26607 (26450-26764) 4 (4-4) -99.98%

Fixes: 62188639ec160 ("nvme-multipath: introduce delayed removal of the multipath head node")
Suggested-by: Nilay Shroff<nilay@xxxxxxxxxxxxx>
Signed-off-by: Qiliang Yuan<qiliang.yuan@xxxxxxxxx>

Looks good to me:

Reviewed-by: Nilay Shroff <nilay@xxxxxxxxxxxxx>