Re: [PATCH v4] platform/x86: asus-wmi: fix camera key LED on Zenbook S14

From: Rong Zhang

Date: Thu Nov 19 2026 - 09:39:14 EST


Hi Devin,

Thanks for your information.

On Thu, 2026-11-19 at 14:57 +0100, Devin Bayer wrote:
>
> On 19/11/2026 14.12, Rong Zhang wrote:
> > > I don't know about query and notifications.
> >
> > Could you test if any event is emitted when you press the camera key? See
> > is_camera_toggle() in Zane's patch for the corresponding event codes.
>
> Is this what you are looking for?
>
> bpftrace -e '
> kprobe:asus_wmi:asus_wmi_notify {
> $obj = (union acpi_object *)arg0;
> printf("_WED type=%u value=0x%016llx\n",
> $obj->type, $obj->integer.value);
> }'
>
> When I press the camera key, doesn't matter if it's disabled (LED on) or
> disabled (LED off):
>
> Attached 1 probe
> _WED type=1 value=0x0000000000000085
> _WED type=1 value=0x0000000000000085
>

This is exactly what I am looking for! Your device can take the advantage
of brightness_hw_changed though CAMERA_NEG, which proves the viability of
my proposal.

>
> > > The hardware key doesn't do anything if it's remapped, at least in my setup.
> >
> > How to "remap" the "hardware key"? Isn't the LED device only "remaps" the
> > status LED?
>
> I mean the hardware key does nothing - it doesn't control the LED or
> camera. 
>

Got it. This is also what I expect. I misinterpreted your word as
remapping the key though hardware (i.e., EC).

Thanks,
Rong

> The desktop keyboard key is remapped in software so the desktop
> doesn't disable the camera when it's pressed.
>
> Cheers,
> Devin