Re: [PATCH v4 0/2] ext4: fix shrinker scan budget accounting, plus a related cleanup
From: Theodore Ts'o
Date: Thu Nov 19 2026 - 09:51:29 EST
On Thu, 01 Oct 2026 15:43:55 +0800, Qiliang Yuan wrote:
> This reverts the v3 simplification of the ext4_es_scan() shrinker
> scan-budget fix, keeping the unrelated locked_ei cleanup from v3.
>
> Patch 1 keys SHRINK_STOP off nr_scanned (extents actually examined)
> again instead of nr_shrunk (extents actually freed). Jan Kara pointed
> out that a batch finding every extent still referenced and freeing
> none of it is still real, useful aging progress, not "nothing left to
> reclaim"; Sashiko AI review independently flagged the same issue.
> This restores Jan Kara's v1 Reviewed-by: the diff in ext4_es_scan()
> and __es_shrink() is unchanged from what he reviewed there (only the
> explanatory comment reads differently).
>
> [...]
Applied, thanks!
[1/2] ext4: fix shrinker scan budget accounting in ext4_es_scan()
commit: ec14be6c39ceb7abc63d1d9ed61f35bf7f45055c
[2/2] ext4: remove unused locked_ei parameter from __es_shrink()
commit: 96b04aafcf777c0f616ff44a7d9cabd4f4551529
Best regards,
--
Theodore Ts'o <tytso@xxxxxxx>