Re: [PATCH] hwmon: add Raspberry Pi DA9091 PMIC driver
From: Guenter Roeck
Date: Thu Nov 19 2026 - 09:57:03 EST
On 11/18/26 23:40, Sander Speetjens wrote:
drivers/hwmon/Kconfig | 11 +
drivers/hwmon/Makefile | 1 +
drivers/hwmon/raspberrypi-da9091.c | 339 +++++++++++++++++++++++++++++
This needs to be documented.
Please clarify?
I would suggest to read and follow
Documentation/hwmon/submitting-patches.rst
which says:
* Document the driver in Documentation/hwmon/<driver_name>.rst.
It is retrieved in rpi_pmic_read and given to rpi_pmic_update to write+ data->hwmon_dev =
+ devm_hwmon_device_register_with_info(dev,
+ "da9091", data, &rpi_pmic_chip_info, NULL);
+ if (IS_ERR(data->hwmon_dev))
+ return PTR_ERR(data->hwmon_dev);
+
+ platform_set_drvdata(pdev, data);
I do not see where this is used.
the values to and to put the last_updated variable in
rpi_pmic_read() calls dev_get_drvdata() on the hardware monitoring device,
not on the platform device.
Guenter