Re: [PATCH 1/5] media: cec: seco: Use named initializers for acpi_device_id
From: Mauro Carvalho Chehab
Date: Thu Nov 19 2026 - 10:09:33 EST
On Thu, 29 Oct 2026 16:54:13 +0000
Pawel Zalewski <pzalewski@xxxxxxxxxxxxxxxxxxxx> wrote:
> Use a designated initializer for the acpi_device_id fields which makes the
> code more readable and consistent with how lists are initialized in the
> rest of the kernel code base. Also drop explicitly setting fields to 0
> where it is redundant.
>
> Unify the list terminator to have a single space between the brackets and
> no trailing comma.
>
> Signed-off-by: Pawel Zalewski <pzalewski@xxxxxxxxxxxxxxxxxxxx>
LGTM.
Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx>
> ---
> drivers/media/cec/platform/seco/seco-cec.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/cec/platform/seco/seco-cec.c b/drivers/media/cec/platform/seco/seco-cec.c
> index 12db6dca602b..2d7ee5638eba 100644
> --- a/drivers/media/cec/platform/seco/seco-cec.c
> +++ b/drivers/media/cec/platform/seco/seco-cec.c
> @@ -768,8 +768,8 @@ static SIMPLE_DEV_PM_OPS(secocec_pm_ops, secocec_suspend, secocec_resume);
>
> #ifdef CONFIG_ACPI
> static const struct acpi_device_id secocec_acpi_match[] = {
> - {"CEC00001", 0},
> - {},
> + { .id = "CEC00001" },
> + { }
> };
>
> MODULE_DEVICE_TABLE(acpi, secocec_acpi_match);
>
Thanks,
Mauro