Re: [PATCH 3/3] wifi: ath10k: don't arm the scan timeout for a scan that did not start
From: Christopher Griffin
Date: Thu Nov 19 2026 - 10:11:10 EST
On 11/5/2026 5:47 PM, Jeff Johnson wrote:
> Please don't send HTML e-mail.
>
> Note your reply was not archived or sent to the mailing list because it was
> HTML. I only received it since I was directly addressed.
Sorry, Jeff, and sorry for the duplicate: my last resend went out as
HTML again. Plain text this time so it lands on the list.
On Thu, Nov 5, 2026 at 9:53 PM Loic Poulain
<loic.poulain@xxxxxxxxxxxxxxxx> wrote:
> It looks more like a theoretical issue than something that is likely
> to occur in practice, but the fix looks good to me.
>
> Reviewed-by: Loic Poulain <loic.poulain@xxxxxxxxxxxxxxxx>
Thanks for the review, Loic.
We did hit it on ath11k, and it did damage: on a QCN9074, a firmware
crash failed a scan start with -110, the timeout was armed anyway, and
it fired after the dead radio had been unbound, ending in "cannot queue
ath11k_scan_timeout_work on wq" with a garbage workqueue, and a panic
(that is patch 2/3).
Whether ath10k ever hits it I don't know, but the code is the same, so
the fix can't hurt.
Christopher Griffin