Re: [RFC PATCH v4 01/18] mm/swap: remove unused parameter for reading swap header

From: Kunwu Chan

Date: Thu Nov 19 2026 - 10:56:29 EST


>
> From: Kairui Song <kasong@xxxxxxxxxxx>
>
> The swap_info_struct argument to read_swap_header() is unused. Remove it
> and update the swapon() call site.
>
> No functional change.
>
> Signed-off-by: Kairui Song <kasong@xxxxxxxxxxx>
> Signed-off-by: Lian Wang <lianux.mm@xxxxxxxxx>
> ---
> mm/swapfile.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/mm/swapfile.c b/mm/swapfile.c
> index fcda5eba1714..c41c4d26a7e6 100644
> --- a/mm/swapfile.c
> +++ b/mm/swapfile.c
> @@ -3630,9 +3630,8 @@ __weak unsigned long arch_max_swapfile_size(void)
> return generic_max_swapfile_size();
> }
>
> -static unsigned long read_swap_header(struct swap_info_struct *si,
> - union swap_header *swap_header,
> - struct inode *inode)
> +static unsigned long read_swap_header(union swap_header *swap_header,
> + struct inode *inode)
> {
> int i;
> unsigned long maxpages;
> @@ -3863,7 +3862,7 @@ SYSCALL_DEFINE2(swapon, const char __user *, specialfile, int, swap_flags)
> }
> swap_header = kmap_local_folio(folio, 0);
>
> - maxpages = read_swap_header(si, swap_header, inode);
> + maxpages = read_swap_header(swap_header, inode);
> if (unlikely(!maxpages)) {
> error = -EINVAL;
> goto bad_swap_unlock_inode;
>

Looks good, thanks!

Reviewed-by: Kunwu Chan <kunwu.chan@xxxxxxxxx>