Re: [PATCH] fork: clear p->mm when copy_process() fails

From: Bradley Morgan

Date: Thu Nov 19 2026 - 11:00:39 EST


On 19 November 2026 08:04:58 GMT, "David Hildenbrand (Arm)"
<david@xxxxxxxxxx> wrote:
>From: Chris Mason <mason@xxxxxxxxxx>
>
>When copy_process() fails after copy_mm(), the error path drops the mm
>reference but leaves p->mm set. Perf and BPF can still reach the
>task, and take a reference on the already freed mm through get_task_mm()
>or bpf_find_vma(), resulting in a use-after-free:
>
> copy_process() PERF_EVENT_IOC_SET_FILTER
> ============== =========================
> perf_event_init_task(p)
> copy_mm(p)
> a later step fails
> mmput(p->mm)
> /* frees the mm */
> perf_event_addr_filters_apply()
> get_task_mm(p)
> /* use-after-free */
>
>Similarly, a BPF program on the task_free LSM hook can call
>bpf_find_vma(p)
>before the task is freed.
>
>Fix it by clearing p->mm under task_lock() before dropping the reference,
>just like exit_mm() does.
>
>Further, if copy_process() fails before copy_mm(), p->mm is still the
>parent's mm pointer copied by dup_task_struct(), without having taken a
>reference. While nobody can access it concurrently, there is the
>chance that it might get accessed later when a BPF program is attached
>to free_task().
>
>With CONFIG_MEMCG the task is freed after an RCU grace period, so the
>parent might already be gone and p->mm in the child points at something
>that was already freed. So let's just clear p->mm before freeing the
>task. No lock is required as there cannot be concurrent access (and we
>might not even have the lock initialized yet).
>
>This has medium urgency.
>
>Fixes: 375637bc5249 ("perf/core: Introduce address range filtering")
>Fixes: 7c7e3d31e785 ("bpf: Introduce helper bpf_find_vma")
>Reported-by: Sashiko <sashiko-bot@xxxxxxxxxx>
>Closes: https://lore.kernel.org/sashiko-outbox-180866@xxxxxxxxxx/
>Cc: stable@xxxxxxxxxxxxxxx
>Signed-off-by: Chris Mason <mason@xxxxxxxxxx>
>[ david: simplify description and comments ]

Reviewed-by: Bradley Morgan <bradley.morgan@xxxxxxxxx>


>Signed-off-by: David Hildenbrand (Arm) <david@xxxxxxxxxx>
>---
>I can take this through my tree (rather soonish) unless someone else
>wants to pick this up.
>---
> kernel/fork.c | 15 +++++++++++++--
> 1 file changed, 13 insertions(+), 2 deletions(-)
>
>diff --git a/kernel/fork.c b/kernel/fork.c
>index 5efceb8d58a78..77d6c8fc38c66 100644
>--- a/kernel/fork.c
>+++ b/kernel/fork.c
>@@ -2628,8 +2628,14 @@ __latent_entropy struct task_struct *copy_process(
> bad_fork_cleanup_mm:
> sched_cache_fork_cleanup(p);
> if (p->mm) {
>- mm_clear_owner(p->mm, p);
>- mmput(p->mm);
>+ struct mm_struct *mm = p->mm;
>+
>+ /* Perf events and BPF programs can still reach p. */
>+ task_lock(p);
>+ p->mm = NULL;
>+ task_unlock(p);
>+ mm_clear_owner(mm, p);
>+ mmput(mm);
> }
> bad_fork_cleanup_signal:
> if (!(clone_flags & CLONE_THREAD))
>@@ -2663,6 +2669,11 @@ __latent_entropy struct task_struct *copy_process(
> exit_cred_namespaces(p);
> exit_creds(p);
> bad_fork_free:
>+ /*
>+ * If set, p->mm points at the parent's mm without a reference. Nobody
>+ * can access it concurrently anymore, but prevent later access.
>+ */
>+ p->mm = NULL;
> WRITE_ONCE(p->__state, TASK_DEAD);
> exit_task_stack_account(p);
> put_task_stack(p);
>
>---
>base-commit: 4405c18c95d2d0f99f6c581ef0ee8591a1aa6ccd
>change-id: 20261119-mm_failed_fork-a46141b503d0
>
>Best regards,
>--
>David Hildenbrand (Arm) <david@xxxxxxxxxx>
>
>
>


--- Thanks!