Re: [PATCH v10 06/13] mfd: nct6694: Move module type macros to shared header
From: Guenter Roeck
Date: Thu Nov 19 2026 - 11:52:21 EST
On Wed, Nov 18, 2026 at 04:16:17PM +0800, a0282524688@xxxxxxxxx wrote:
> From: Ming Yu <a0282524688@xxxxxxxxx>
>
> Each sub-device driver defines the module type used by its own
> commands. The upcoming HIF transport also needs to recognise
> NCT6694_RPT_MOD, as report accesses are served from a separate
> register space rather than through the command mailbox.
>
> Move all module types into the shared header so that the transports
> and the sub-device drivers use a single set of definitions.
>
> No functional change.
>
> Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxx>
> Signed-off-by: Ming Yu <a0282524688@xxxxxxxxx>
> ---
> Changes in v10:
> - None.
>
> Changes in v9:
> - Added Andi's Reviewed-by.
>
> Changes in v8:
> - Reworded the commit message to explain why the transport needs the
> module types.
>
> Changes in v7:
> - None.
>
> Changes in v6:
> - None.
>
> Changes in v5:
> - Split from the monolithic v4 patch to follow the single logical change
> principle.
>
> drivers/gpio/gpio-nct6694.c | 7 -------
> drivers/hwmon/nct6694-hwmon.c | 21 ---------------------
> drivers/i2c/busses/i2c-nct6694.c | 7 -------
> drivers/net/can/usb/nct6694_canfd.c | 6 ------
> drivers/rtc/rtc-nct6694.c | 7 -------
> drivers/watchdog/nct6694_wdt.c | 7 -------
> include/linux/mfd/nct6694.h | 9 +++++++++
> 7 files changed, 9 insertions(+), 55 deletions(-)
For hwmon and watchdog:
Acked-by: Guenter Roeck <linux@xxxxxxxxxxxx>
Guenter