Re: [PATCH v3 0/9] mm: distinguish HW PTE pointers from SW PTE value pointers

From: David Hildenbrand (Arm)

Date: Thu Nov 19 2026 - 12:00:45 EST


On 11/18/26 22:48, Muhammad Usama Anjum wrote:
> On 16/11/2026 6:18 pm, David Hildenbrand (Arm) wrote:
>> On 11/16/26 18:41, Catalin Marinas wrote:
>>> Hi Usama,
>>>
>> Hi,
>>
>> David here :)
>>
>>> (trimmed the Cc list, some lists reject it as too many recipients)
>>>
>>>
>>> [...]
>>>
>>>
>>> I looked at this (and the arm64 counterpart) and I'm not fully convinced
>>> it's worth the effort (but I won't oppose it if the mm folk decide to go
>>> this route).
>>
>> I think this is the right thing to do to get type safety.
>>
>>>
>>> First, I'd like to see all such on-stack p*d pointers addressed as a
>>> prerequisite (e.g. fix pmd_populate() in __split_huge_zero_page_pmd()).
>>> If for some reason we deem pmd not fixable, I don't like half (or
>>> quarter) baked solutions just addressing the pte.
>>
>> IIRC doing the full PxD conversion is quite big; doens't make sense to post
>> these on the list and instead move stepwise.
>>
>> Agreed that it would be nice to get rid of all stack usage first.
>>
>>>
>>> Second, we could add a run-time page table check, at least for pmd/pte.
>>> Something like below, gated by CONFIG_PAGE_TABLE_CHECK or
>>> CONFIG_DEBUG_VM (untested and not entirely sure about using
>>> PageTable()):
>>>
>>> static inline void pgtable_ptr_check(struct mm_struct *mm, const void *p)
>>> {
>>> if (object_is_on_stack(p)) {
>>> WARN_ON_ONCE(1);
>>> return;
>>> }
>>> if (mm != &init_mm && virt_addr_valid(p))
>>> WARN_ON_ONCE(!PageTable(virt_to_page(p)));
>>> }
>>>
>>> You already have some coccinelle patches to make the conversion. Could
>>> we turn them into a coccicheck to detect new uses? With LLM reviews like
>>> Sashiko, we can probably catch new uses violating the requirement (we
>>> need to document it).
>>>
>>> LLMs and coccicheck won't catch all abuses nor does this series prevent
>>> one from declaring hw_pte_t on the stack.
>>>
>>> Once the above are in place, I'd look again at these patches and see
>>> whether they improve code clarity and are worth the churn.
>>>
>>> Maybe an argument in favour of these patchsets is future dynamic support
>>> for FEAT_D128, we'd need to separate the software representation of a
>>> pte from the hardware one but we've done this before (arm32 non-LPAE has
>>> different representations).
>>
>> Exactly; we'll need this and go one step further and disallow any ptep++ to
>> instead route this through helpers.
>
> Agreed, after the current series, we can easily make hw_pte_t opaque like the
> following (or in even better way if we spend some more time thinking about it):
>

Yes, exactly.

--
Cheers,

David