Re: [PATCH RFC v4] ALSA: pci: add analog support for ESI MAYA44e
From: Nordschamane
Date: Thu Nov 19 2026 - 12:04:40 EST
Hi Takashi,
Thanks for reviewing the driver.
> First, off, as Signed-off-by is a legal requirement, could you try to
> fill a real name here? At best align the From address together, too.
Nordschamane is my long-standing public nickname. I use it consistently
for this project and prefer to keep my legal name private. The same name
and contact address are in the patch author field and Signed-off-by
trailer, and I can be reached at that address.
The kernel submission guide asks for a "known identity". Linus changed
the previous wording and explained in the commit message that the kernel
has accepted nicknames:
https://github.com/torvalds/linux/commit/d4563201f33a022fc0353033d9dfeb1606a88330
https://docs.kernel.org/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin
> Try to use guard() & co instead of the open mutex or spin lock
> calls.
v5 uses guard() and scoped_guard() for the codec mutex and register
spinlock.
> Most of such stop synchronization should have been done in
> sync_stop callback, instead.
Each direction now owns its fault work. The trigger stops DMA for that
direction, and sync_stop waits for the shared IRQ and that direction's
queued work. The close callback clears the substream pointer.
> Do we really need a manual expansion and the format conversion in a
> loop there at all?
I removed the ack callback and its sample conversion. The driver
exposes the native S32_LE format (24 significant bits) and maps both
stereo DMA rings directly via MMAP_COMPLEX. The RW_INTERLEAVED fallback
still rearranges stereo frames to match the two hardware rings. It
copies the sample words as-is, outside the stream lock.
I tested the final v5 on a MAYA44e. Both output pairs and four-channel
capture ran in both access modes at 48 and 96 kHz. Duplex ran at 96 kHz,
and all 40 linked PREPARE/RESET cycles passed. The inputs were undriven.
v5: https://lore.kernel.org/r/20261120-codex-alsa-maya44e-v5-1-49f3682dfc81@xxxxxxxxx
Thanks,
Nordschamane