Re: [PATCH v8 08/14] drm/bridge: it6505: avoid division by zero in audio FS debug print

From: Luca Ceresoli

Date: Thu Nov 19 2026 - 12:05:52 EST


On Thu Nov 19, 2026 at 5:26 PM CET, Daniel Golle wrote:
> On Wed, Nov 18, 2026 at 03:12:14AM +0000, Hermes.Wu@xxxxxxxxxx wrote:
>> Hi Daniel, Luca,
>>
>> On Mon, Nov 16, 2026 at 08:56:18AM +0000, Daniel Golle wrote:
>> > On Tue, Oct 20, 2026 at 06:51:39PM +0200, Luca Ceresoli wrote:
>> > > If you could share what that register is for, it would probably answer some
>> > > of those questions.
>> >
>> > I don't have documentation for it either, and with ITE gone there is
>> > nobody left to ask.
>>
>> REG_AUDIO_INPUT_FREQ (0xBE) is a read-only input audio frequency
>> counter. The driver uses it to check whether the I2S BCLK is
>> present and changing, i.e. whether there is audio input.
>
> Great to see you are actually still around, and thank you for confirming
> that we can drop the register read there.
>
> I was afraid the bouncing emails of the former driver maintainers would
> indicate the driver has now been orphaned. It'd hence be great if you
> can enlist yourself in the MAINTAINERS file for that driver.
>
>> > As for the logging, I don't think it is worth an extra i2c read and a
>> > division in the enable path, so in v9 I'll drop the read and the
>> > print from it6505_enable_audio() instead of guarding the division.
>>
>> Fine with us, the value is only informational there.
>
> +1

Ah, great, thanks Hermes for the feedback and Daniel for the patience in
getting to the bottom of this!

Luca

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com