Re: [PATCH v2 1/4] dt-bindings: iio: light: stk33xx: add power supply support
From: Roman Vivchar
Date: Thu Nov 19 2026 - 12:22:23 EST
Hi Conor,
On Thursday, November 19th, 2026 at 6:37 PM, Conor Dooley <conor@xxxxxxxxxx> wrote:
> On Thu, Nov 19, 2026 at 03:29:03AM +0000, Jonathan Cameron wrote:
> > On Wed, 18 Nov 2026 18:12:30 +0000
> > Conor Dooley <conor@xxxxxxxxxx> wrote:
> >
> > > On Tue, Nov 17, 2026 at 08:08:35PM +0200, Roman Vivchar via B4 Relay wrote:
> > > > From: Roman Vivchar <rva333@xxxxxxxxxxxxxx>
> > > >
> > > > On some boards, the chip shares a power rail with other components. If
> > > > that rail is turned off, the chip can't function.
> > >
> > > With these issues in mind, probably it should be made required, even
> > > though new required properties are an ABI break.
> >
> > I raised the same on v1. Seems it is used by various boards
> > in tree where we don't know which supply it is. So whilst nice
> > to fix we might just be creating some painful build warnings.
>
> Yeah I don't really want to cause more warnings, but if it is actually
> the source of issues, warning may get them resolved.
>
> Up to Roman really I guess.
Sadly I don't have schematic for these boards in upstream, so I guess
the safest approach is leaving it as optional, since most devices have
power rail shared with almost always-on components (like eMMC or other
sensors).
Best regards,
Roman
>
> > Can go ahead and 'guess' I suppose or put a fixed supply on it
> > in the upstream dts.
> >
> > Jonathan
> >
> > >
> > > >
> > > > Add vdd-supply property to document the chip power supply.
> > > >
> > > > Signed-off-by: Roman Vivchar <rva333@xxxxxxxxxxxxxx>
> > > > ---
> > > > Documentation/devicetree/bindings/iio/light/stk33xx.yaml | 2 ++
> > > > 1 file changed, 2 insertions(+)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/iio/light/stk33xx.yaml b/Documentation/devicetree/bindings/iio/light/stk33xx.yaml
> > > > index f655a570aac7..114cf87eb54d 100644
> > > > --- a/Documentation/devicetree/bindings/iio/light/stk33xx.yaml
> > > > +++ b/Documentation/devicetree/bindings/iio/light/stk33xx.yaml
> > > > @@ -37,6 +37,8 @@ properties:
> > > >
> > > > proximity-near-level: true
> > > >
> > > > + vdd-supply: true
> > > > +
> > > > required:
> > > > - compatible
> > > > - reg
> > > >
> > > > --
> > > > 2.56.1
> > > >
> > > >
> >
>