Re: [PATCH] dmaengine: dw: Use devm_clk_get_optional_enabled() in dw_probe()

From: Frank Li

Date: Thu Nov 19 2026 - 12:42:16 EST


On Thu, Nov 19, 2026 at 06:22:41PM +0100, Markus Elfring wrote:
> >> Thank you for your contribution! Sashiko AI review found 1 potential
> >> issue to consider:
> >> - [High] dmaengine: dw: double clk_disable_unprepare() in dw_probe() and
> >> dw_remove()
> >> --
> >>
> >> commit ff07f5838666895fdb235cca7d9f7155e7085b00
> >> Author: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> >>
> >> dmaengine: dw: Use devm_clk_get_optional_enabled() in dw_probe()
> >>
> >> This commit replaces devm_clk_get_optional() and clk_prepare_enable() in
> >> dw_probe() with devm_clk_get_optional_enabled().
> >>
> >>> diff --git a/drivers/dma/dw/platform.c b/drivers/dma/dw/platform.c
> >>> index 7e76391475ac1..9bb3c2cd08570 100644
> >>> --- a/drivers/dma/dw/platform.c
> >>> +++ b/drivers/dma/dw/platform.c
> >>> @@ -64,12 +64,9 @@ static int dw_probe(struct platform_device *pdev)
> >>>
> >>> data->chip = chip;
> >>>
> >>> - chip->clk = devm_clk_get_optional(chip->dev, "hclk");
> >>> + chip->clk = devm_clk_get_optional_enabled(chip->dev, "hclk");
> >>> if (IS_ERR(chip->clk))
> >>> return PTR_ERR(chip->clk);
> >>> - ret = clk_prepare_enable(chip->clk);
> >>> - if (ret)
> >>> - return ret;
> >>>
> >>> pm_runtime_enable(&pdev->dev);
> >>>
> >>
> >> [Severity: High]
> >> Does this cause a double clk_disable_unprepare() on chip->clk?
> >>
> >> devm_clk_get_optional_enabled() registers a devres cleanup that disables
> >> and unprepares chip->clk automatically, but both the err_dw_dma_probe
> >> error path in dw_probe() and dw_remove() still call
> >> clk_disable_unprepare(chip->clk) manually. When data->probe() fails or
> >> the device is unbound, chip->clk is disabled and unprepared twice,
> >> underflowing the clock reference counts and triggering WARN() splats in
> >> the clock core.
> >
> > Please fix this problem
>
> Do you find these two function calls really not equivalent to another known function call?
> https://elixir.bootlin.com/linux/v7.4-rc1/source/include/linux/clk.h#L680-L699

What's your point? Sashiko just remind you need remove
clk unprepare at error path and remove() function

Frank
>
> Regards,
> Markus
>
>
> …
> >> --
> >> Sashiko AI review · https://sashiko.dev/#/patchset/8e3534b7-ae64-4c1f-819d-0ba390737b84@xxxxxx?part=1
>