[PATCH wireless-next 02/10] wifi: cw1200: check SDD element lengths before reading them

From: Arthur Heymans

Date: Thu Nov 19 2026 - 12:50:33 EST


SDD elements have byte alignment. Read the PTA and reference clock
fields with get_unaligned_le16() and reject short elements instead of
using incomplete board configuration data.

Prepared with OpenAI Codex.

Fixes: a910e4a94f69 ("cw1200: add driver for the ST-E CW1100 & CW1200 WLAN chipsets")
Signed-off-by: Arthur Heymans <arthur@xxxxxxxxxxxx>
---
drivers/net/wireless/st/cw1200/sta.c | 26 +++++++++++++++++++-------
1 file changed, 19 insertions(+), 7 deletions(-)

diff --git a/drivers/net/wireless/st/cw1200/sta.c b/drivers/net/wireless/st/cw1200/sta.c
index 5d8eaa700779..db9f0c4a07aa 100644
--- a/drivers/net/wireless/st/cw1200/sta.c
+++ b/drivers/net/wireless/st/cw1200/sta.c
@@ -11,6 +11,7 @@
#include <linux/firmware.h>
#include <linux/module.h>
#include <linux/etherdevice.h>
+#include <linux/unaligned.h>

#include "cw1200.h"
#include "sta.h"
@@ -1072,28 +1073,34 @@ static int cw1200_parse_sdd_file(struct cw1200_common *priv)
while (p + 2 <= priv->sdd->data + priv->sdd->size) {
if (p + p[1] + 2 > priv->sdd->data + priv->sdd->size) {
pr_warn("Malformed sdd structure\n");
- return -1;
+ return -EINVAL;
}
switch (p[0]) {
case SDD_PTA_CFG_ELT_ID: {
u16 v;
+
if (p[1] < 4) {
pr_warn("SDD_PTA_CFG_ELT_ID malformed\n");
- ret = -1;
- break;
+ return -EINVAL;
}
- v = le16_to_cpu(*((__le16 *)(p + 2)));
+ v = get_unaligned_le16(p + 2);
if (!v) /* non-zero means this is enabled */
break;

- v = le16_to_cpu(*((__le16 *)(p + 4)));
+ v = get_unaligned_le16(p + 4);
priv->conf_listen_interval = (v >> 7) & 0x1F;
pr_debug("PTA found; Listen Interval %d\n",
priv->conf_listen_interval);
break;
}
case SDD_REFERENCE_FREQUENCY_ELT_ID: {
- u16 clk = le16_to_cpu(*((__le16 *)(p + 2)));
+ u16 clk;
+
+ if (p[1] < sizeof(clk)) {
+ pr_warn("SDD reference frequency malformed\n");
+ return -EINVAL;
+ }
+ clk = get_unaligned_le16(p + 2);
if (clk != priv->hw_refclk)
pr_warn("SDD file doesn't match configured refclk (%d vs %d)\n",
clk, priv->hw_refclk);
@@ -1147,7 +1154,12 @@ int cw1200_setup_mac(struct cw1200_common *priv)
pr_err("Can't load sdd file %s.\n", priv->sdd_path);
return ret;
}
- cw1200_parse_sdd_file(priv);
+ ret = cw1200_parse_sdd_file(priv);
+ if (ret) {
+ release_firmware(priv->sdd);
+ priv->sdd = NULL;
+ return ret;
+ }
}

cfg.dpdData = priv->sdd->data;
--
2.56.0