Re: [PATCH bpf-next v1 0/4] libbpf: Support kernel-side kfunc flavors
From: Eduard Zingerman
Date: Thu Nov 19 2026 - 12:51:16 EST
On Wed, 2026-11-18 at 16:13 -0700, Ihor Solodrai wrote:
...
> > Maybe I have reading comprehension issues, but in order to decipher it
> > one has to:
> > - "kept old prototype" - figure out that two functions were declared
> > "scx_bpf_dsq_insert" and "scx_bpf_dsq_insert___compat"
> > - "bind old binaries to it and broke them" - figure out that existing
> > bpf programs referred to "scx_bpf_dsq_insert" and libbpf mechanics
> > didn't work as expected.
> > - "reversed the naming" - like a new function became ___compat or what
> > happened?
> > - "A ___v2 kfunc declared as vmlinux.h spells it ..."
> > Now there is a ___v2 in the picture.
> > - "... doesn't bind" - figure out that this refers to libbpf mechanics.
> > - "fixed a compat macro that silently dropped enq_flags because of this."
> > Incomprehensible w/o looking in the code.
>
> Your reading is a valid approach to understand the history in more
> details, and you are correct that the paragraph does not provide them.
>
> However IMO those details are unnecessary in the cover, but pointers
> are useful. Which is why I left this ai-generated paragraph be.
Examples are very helpful in cover letters, they save reviewers time
and make the changes easier to understand for people monitoring the
list.