Re: [PATCH v2] ftrace: Reject "!!" in front of a set_ftrace_filter command

From: Steven Rostedt

Date: Thu Nov 19 2026 - 12:59:38 EST


On Wed, 18 Nov 2026 19:09:00 -0800
Yifan Feng <evanfengff@xxxxxxxxx> wrote:

> diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
> index c7d74b33d36d..44a861f021be 100644
> --- a/kernel/trace/ftrace.c
> +++ b/kernel/trace/ftrace.c
> @@ -5846,6 +5846,9 @@ static int ftrace_process_regex(struct ftrace_iterator *iter,
>
> /* command found */
>

A comment is needed here. Something like:

/*
* A double "!!" confuses the parser. This isn't a boolean operation,
* simply reject it.
*/

> + if (func[0] == '!' && func[1] == '!')
> + return -EINVAL;
> +
> command = strsep(&next, ":");
>
> guard(mutex)(&ftrace_cmd_mutex);

-- Steve