Re: [PATCH] mm/backing-dev: pass "%s" format string to device_create() in bdi_register_va()

From: Lorenzo Stoakes (ARM)

Date: Thu Nov 19 2026 - 13:26:43 EST


On Thu, Nov 19, 2026 at 09:05:17AM -0800, Ian Rogers wrote:
> bdi_register_va() formats (fmt, args) into bdi->dev_name via vsnprintf()
> and then passes bdi->dev_name directly as the format string argument to
> device_create(), causing vsnprintf() to run a second time on the already
> formatted device name with no variadic arguments. If a caller formats an
> identifier containing '%', device_create() interprets it as format
> specifiers and reads arbitrary stack slots.
>
> Pass "%s", bdi->dev_name to device_create().
>
> Found via an x86_64 LLVM=1 (Clang 21.1.8) allyesconfig audit with
> -Wformat-security enabled; fix and changelog drafted with an AI coding
> assistant. Build-tested under LLVM=1 W=1 and -Wformat-security; not
> runtime-tested with '%' in backing-device names.
>
> Fixes: 6bd87eec23cb ("bdi: add a ->dev_name field to struct backing_dev_info")
> Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>

Seems reasonable so:

Acked-by: Lorenzo Stoakes (ARM) <ljs@xxxxxxxxxx>

> ---
> mm/backing-dev.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/mm/backing-dev.c b/mm/backing-dev.c
> index fad1495d3b20..58373d494d92 100644
> --- a/mm/backing-dev.c
> +++ b/mm/backing-dev.c
> @@ -1097,7 +1097,8 @@ int bdi_register_va(struct backing_dev_info *bdi, const char *fmt, va_list args)
> return 0;
>
> vsnprintf(bdi->dev_name, sizeof(bdi->dev_name), fmt, args);
> - dev = device_create(&bdi_class, NULL, MKDEV(0, 0), bdi, bdi->dev_name);
> + dev = device_create(&bdi_class, NULL, MKDEV(0, 0), bdi, "%s",
> + bdi->dev_name);
> if (IS_ERR(dev))
> return PTR_ERR(dev);
>
> --
> 2.56.1.708.g77570a6a1d-goog
>

--
Cheers, Lorenzo