Re: [PATCH net] net/mlx5e: Skip hairpin entries not ready in debugfs dump

From: Tariq Toukan

Date: Thu Nov 19 2026 - 13:28:58 EST




On 19/11/2026 3:27, Changyul Lee wrote:
Hairpin entries are added to the table before creation completes.
Reading hairpin_table_dump can therefore dereference a NULL pointer
while creation is in progress, or an error pointer if creation fails.

Skip entries that are still being created or whose creation failed.

Fixes: 0e414518d6d8 ("net/mlx5e: Add hairpin debugfs files")
The dump added by that commit printed only peer_vhca_id, prio and
refcnt, it did not touch hpe->hp. The dereference came later, in v6.4,
so this should be:

Fixes: 8a0594c09610 ("net/mlx5e: Add more information to hairpin table dump")

The change itself looks good to me.

With the tag fixed, you can add:
Reviewed-by: Tariq Toukan <tariqt@xxxxxxxxxx>

Thanks,
Tariq