Re: [PATCH net-next v4 0/4] TCP Prague preparation series

From: Eric Dumazet

Date: Thu Nov 19 2026 - 13:42:07 EST


Le jeu. 19 nov. 2026 à 19:01, <chia-yu.chang@xxxxxxxxxxxxxxxxxxx> a écrit :
>
> From: Chia-Yu Chang <chia-yu.chang@xxxxxxxxxxxxxxxxxxx>
>
> Hello,
>
> Please find the v3 TCP Prague preparation series, and TCP Prague will
> be submitted after this series.

This is v4, and I could not find what changed since v3 : all the
changelogs stop at v3.

Also, the changelogs are placed after a "--" line instead of "---",
so they would end up in the commit messages.

This series does not apply to net-next. Patch 1 fails on
net/ipv4/tcp_input.c, because it expects tcp_accecn_process() to
have a prior_bytes_acked argument. I do not see this in net-next,
net or Linus tree. What is the base of this series ?

More generally, this adds a new tcp_congestion_ops method, a new
ecn_flags bit, and two exports, without any in-tree user.
It is hard to review these in isolation. I would prefer to see them
in the same series as the congestion control module using them.

More comments on individual patches.


>
> This patch includes the following additions:
> (1) Export CE count in rate_sample as acked_sacked_ce;
> (2) Rename existing rename ECN transmit helper function;
> (3) Add TCP_ECN_SEND_ECT_1 to use ECT_1 after negotiation;
> (4) Add MSS ceiling callback for congestion control to limit MSS.
>
> Best regards,
> Chia-Yu
>
> ---
> Chia-Yu Chang (3):
> tcp: rename ECN transmit helper function
> tcp: add TCP_ECN_SEND_ECT_1 flag for congestion control
> tcp: add MSS ceiling callback for congestion control
>
> Ilpo Järvinen (1):
> tcp: export CE count in rate_sample
>
> include/net/tcp.h | 6 ++++++
> include/net/tcp_ecn.h | 12 +++++++++---
> net/ipv4/tcp_cong.c | 8 +++++---
> net/ipv4/tcp_input.c | 40 +++++++++++++++++++---------------------
> net/ipv4/tcp_output.c | 18 +++++++++++++++++-
> 5 files changed, 56 insertions(+), 28 deletions(-)
>
> --
> 2.34.1
>