Re: [PATCH v6 3/4] MIPS: Ingenic: Add XBurst SMP support
From: Maciej W. Rozycki
Date: Thu Nov 19 2026 - 14:18:06 EST
On Fri, 13 Nov 2026, Florian Fainelli wrote:
> diff --git a/arch/mips/ingenic/ingenic-smp-entry.S b/arch/mips/ingenic/ingenic-smp-entry.S
> new file mode 100644
> index 000000000000..290e23c65707
> --- /dev/null
> +++ b/arch/mips/ingenic/ingenic-smp-entry.S
> @@ -0,0 +1,54 @@
> +/* SPDX-License-Identifier: GPL-2.0-or-later */
> +/*
> + * Copyright (C) 2013 Paul Burton <paulburton@xxxxxxxxxx>
> + * XBurst secondary CPU reset entry
> + */
> +
> +#include <asm/addrspace.h>
> +#include <asm/asm.h>
> +#include <asm/asmmacro.h>
> +#include <asm/cacheops.h>
> +#include <asm/mipsregs.h>
> +
> +#define CACHE_SIZE (32 * 1024)
> +#define CACHE_LINESIZE 32
> +
> + /* The CP0 REIM register only stores the upper 16 address bits. */
> + .section .text.smp-entry, "ax"
> + .balign 0x10000
> + .set noreorder
What's the point of making this code `noreorder'? We want to avoid such
code whenever possible.
Maciej