Re: [PATCH v3 3/6] clk: stm32: Add STM32MP25 SYSCFG clock driver

From: Brian Masney

Date: Thu Nov 19 2026 - 14:20:18 EST


Hi Gabriel,

> On STM32MP23x and STM32MP25x, the LTDC pixel clock is selected in the
> SYSCFG DISPLAYCLKCR register among the DSI PHY byte lane clock, the LVDS
> PHY pixel clock (reset value) and the LTDC kernel clock, the latter
> being the one needed by the RGB (DPI) output.
>
> The SYSCFG node is described as the provider of this clock, but no
> driver registers it, so the selection can't be changed from its reset
> value and a display connected to the LTDC RGB output can't work.
>
> Add a driver registering this clock as a mux. The SYSCFG node is bound
> to the STM32MP2 SYSCFG driver, so this driver is an auxiliary driver,
> probed from an auxiliary device which shares the SYSCFG node. The mux
> parents are taken from the "clocks" property of the SYSCFG node, which
> remains the clock provider.
>
> Co-developed-by: Dario Binacchi <dario.binacchi@xxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Dario Binacchi <dario.binacchi@xxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Gabriel Fernandez <gabriel.fernandez@xxxxxxxxxxx>
> ---
> drivers/clk/stm32/Kconfig | 13 ++++
> drivers/clk/stm32/Makefile | 1 +
> drivers/clk/stm32/clk-stm32mp25-syscfg.c | 125 +++++++++++++++++++++++++++++++
> 3 files changed, 139 insertions(+)
>
> diff --git a/drivers/clk/stm32/Kconfig b/drivers/clk/stm32/Kconfig
> index 5dbd75cde657..18289816f030 100644
> --- a/drivers/clk/stm32/Kconfig
> +++ b/drivers/clk/stm32/Kconfig
> @@ -39,5 +39,18 @@ config COMMON_CLK_STM32MP257
> help
> Support for stm32mp25x SoC family clocks.
>
> +config COMMON_CLK_STM32MP25_SYSCFG
> + tristate "Clock driver for stm32mp25x SYSCFG clocks"
> + depends on COMMON_CLK_STM32MP257
> + depends on SOC_STM32MP2 || COMPILE_TEST
> + select AUXILIARY_BUS
> + select MFD_SYSCON
> + default COMMON_CLK_STM32MP257
> + help
> + Support for the clocks provided by the stm32mp25x SYSCFG, i.e.
> + the LTDC pixel clock source selection between the LTDC kernel
> + clock (RGB output), the LVDS PHY pixel clock and the DSI byte
> + lane clock.
> +
> endif
>
> diff --git a/drivers/clk/stm32/Makefile b/drivers/clk/stm32/Makefile
> index e04727b59449..8088d172651f 100644
> --- a/drivers/clk/stm32/Makefile
> +++ b/drivers/clk/stm32/Makefile
> @@ -2,3 +2,4 @@ obj-$(CONFIG_COMMON_CLK_STM32MP135) += clk-stm32mp13.o clk-stm32-core.o reset-st
> obj-$(CONFIG_COMMON_CLK_STM32MP157) += clk-stm32mp1.o reset-stm32.o
> obj-$(CONFIG_COMMON_CLK_STM32MP215) += clk-stm32mp21.o clk-stm32-core.o reset-stm32.o
> obj-$(CONFIG_COMMON_CLK_STM32MP257) += clk-stm32mp25.o clk-stm32-core.o reset-stm32.o
> +obj-$(CONFIG_COMMON_CLK_STM32MP25_SYSCFG) += clk-stm32mp25-syscfg.o
> diff --git a/drivers/clk/stm32/clk-stm32mp25-syscfg.c b/drivers/clk/stm32/clk-stm32mp25-syscfg.c
> new file mode 100644
> index 000000000000..41f40325a10f
> --- /dev/null
> +++ b/drivers/clk/stm32/clk-stm32mp25-syscfg.c
> @@ -0,0 +1,125 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Copyright (C) STMicroelectronics 2026 - All Rights Reserved
> + * Author: Gabriel Fernandez <gabriel.fernandez@xxxxxxxxxxx> for STMicroelectronics.
> + */
> +
> +#include <linux/auxiliary_bus.h>
> +#include <linux/bitfield.h>
> +#include <linux/bits.h>
> +#include <linux/clk-provider.h>
> +#include <linux/err.h>
> +#include <linux/limits.h>
> +#include <linux/mfd/syscon.h>
> +#include <linux/module.h>
> +#include <linux/printk.h>
> +#include <linux/regmap.h>
> +
> +#define SYSCFG_DISPLAYCLKCR 0x5000
> +#define DISPLAYCLKCR_DPIVSLVDS GENMASK(1, 0)
> +
> +/*
> + * The LTDC pixel clock source is selected in SYSCFG_DISPLAYCLKCR among
> + * the DSI byte lane clock, the LVDS PHY pixel clock (reset value) and
> + * the LTDC kernel clock, which is used with the RGB (DPI) output.
> + *
> + * The parents are listed in the DPIVSLVDS field order, while .index refers
> + * to the "clocks" property of the SYSCFG node, ordered "ltdc", "lvds", "dsi"
> + * so that the inputs missing on a SoC can be omitted at the end of the list.
> + */
> +static const struct clk_parent_data clk_pix_ltdc_parents[] = {
> + { .index = 2 }, /* dsi */
> + { .index = 1 }, /* lvds */
> + { .index = 0 }, /* ltdc */
> +};
> +
> +struct stm32mp25_syscfg_mux {
> + struct clk_hw hw;
> + struct regmap *regmap;
> +};
> +
> +static inline struct stm32mp25_syscfg_mux *to_syscfg_mux(struct clk_hw *hw)
> +{
> + return container_of(hw, struct stm32mp25_syscfg_mux, hw);
> +}
> +
> +static u8 stm32mp25_syscfg_mux_get_parent(struct clk_hw *hw)
> +{
> + struct stm32mp25_syscfg_mux *mux = to_syscfg_mux(hw);
> + unsigned int val;
> + int ret;
> +
> + ret = regmap_read(mux->regmap, SYSCFG_DISPLAYCLKCR, &val);
> + if (ret) {
> + pr_err("%s: failed to read the parent: %pe\n",

You have the struct dev in the probe function below. Save a pointer to
the dev in struct stm32mp25_syscfg_mux, and then you can use dev_err()
here.

With that fixed:

Reviewed-by: Brian Masney <masneyb@xxxxxxxxxx>

--
Brian Masney <masneyb@xxxxxxxxxx>