Re: [PATCH v2 00/14] s390/sclp: replace page allocator calls with k[mz]alloc()

From: Alexander Gordeev

Date: Thu Nov 19 2026 - 14:55:18 EST


On Tue, Nov 17, 2026 at 03:06:52PM +0200, Mike Rapoport (Microsoft) wrote:
> This the next episode of conversion of page allocator calls to kmalloc
> family :)
>
> This series covers SCLP buffer allocations.
>
> = tl;dr cover letter copied from the previous posts:
>
> This is a (small) part of larger work of replacing page allocator calls
> with kmalloc.
>
> My initial intention a few month ago was to remove ugly casts [1], but then
> willy pointed out that Linus objected to something like this [2] and it
> looks like more than a decade old technical debt.
>
> Largely, anything that doesn't need struct page (or a memdesc in the
> future) should just use kmalloc() or kvmalloc() to allocate memory.
> kmalloc() guarantees alignment, physical contiguity and working
> virt_to_phys() and beside nicer API that returns void * on alloc and
> doesn't require to know the allocation size on free, kmalloc() provides
> better debugging capabilities than page allocator.
>
> Another thing is that touching these allocation sites gives the reviewers
> opportunity to see if a PAGE_SIZE buffer is actually needed or maybe
> another size is appropriate.
>
> For larger allocations that don't need physically contiguous memory
> kvmalloc() can be a better option that __get_free_pages() because under
> memory pressure it's is easier to allocate several order-0 pages than a
> physically contiguous chunk with the same number of pages.
>
> And last, but not least, removing needless calls to page allocator should
> help with memdesc (aka project folio) conversion. There will be way less
> places to audit to see if the user was actually using struct page.
>
> The patches are deliberately kept small, so that every conversion can be
> reviewed, and if needed reverted, on its own.
>
> Also in git:
> https://git.kernel.org/pub/scm/linux/kernel/git/rppt/linux.git gfp-to-kmalloc/s390-sclp
>
> [1] https://lore.kernel.org/all/20251018093002.3660549-1-rppt@xxxxxxxxxx/
> [2] https://lore.kernel.org/all/CA+55aFwp4iy4rtX2gE2WjBGFL=NxMVnoFeHqYa2j1dYOMMGqxg@xxxxxxxxxxxxxx/
...
> drivers/s390/char/sclp.c | 9 +++++----
> drivers/s390/char/sclp_ap.c | 4 ++--
> drivers/s390/char/sclp_cmd.c | 13 +++++++------
> drivers/s390/char/sclp_con.c | 5 +++--
> drivers/s390/char/sclp_config.c | 4 ++--
> drivers/s390/char/sclp_cpi_sys.c | 4 ++--
> drivers/s390/char/sclp_ctl.c | 5 +++--
> drivers/s390/char/sclp_ftp.c | 14 ++++++--------
> drivers/s390/char/sclp_mem.c | 12 ++++++------
> drivers/s390/char/sclp_pci.c | 8 ++++----
> drivers/s390/char/sclp_sd.c | 20 ++++++++++----------
> drivers/s390/char/sclp_sdias.c | 5 +++--
> drivers/s390/char/sclp_tty.c | 5 +++--
> drivers/s390/char/sclp_vt220.c | 4 ++--
> 14 files changed, 58 insertions(+), 54 deletions(-)
> ---
> base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
> change-id: 20260907-s390-sclp-ready-05ebba1ea5e9

Applied, thanks!

> --
> Sincerely yours,
> Mike.