Re: [PATCH] x86/realmode: Consolidate real-mode blob size calculation

From: Dave Hansen

Date: Thu Nov 19 2026 - 14:56:40 EST


On 11/13/26 15:33, Thorsten Blum wrote:
> rmpiggy.S page-aligns both real_mode_blob and real_mode_blob_end. Their
> difference is therefore already page-aligned and does not require
> ALIGN() or PAGE_ALIGN().
>
> Since the real-mode blob size is calculated in three different places,
> add the real_mode_blob_size() helper and use it in
> real_mode_size_needed(), setup_real_mode(), and
> set_real_mode_permissions().
>
> No functional change.

Hi Thorsten,

For me, it's a pass on patches like these. They have a real risk of
causing regressions and don't meaningfully make the code more maintainable.

So, it's all downside.

These are hurting the kernel more than helping at the moment. Please stop.