[PATCH v8 27/33] sched/deadline: Start a period at a deboost out of the class
From: Mathieu Desnoyers
Date: Thu Nov 19 2026 - 15:19:13 EST
A task that leaves SCHED_DEADLINE keeps its parameters, runtime and
deadline until its 0-lag time. Commit a649f237db18 ("sched,dl: Fix sched
class hopping CBS hole") keeps them. So leaving and coming back gains
nothing. A priority inheritance boost before then keeps them too.
replenish_dl_entity() takes the donor's runtime and deadline only for a
task with no parameters of its own.
A boosted task is not throttled. When it runs out of runtime, it is
refilled from the donor's parameters. If the task stays in the class at
its deboost, "sched/deadline: Reset the donor's runtime at a deboost in
the class" starts a new period.
A task that leaves the class at its deboost is missed. switched_from_dl()
calls task_non_contending(), which computes the 0-lag time from the
runtime and deadline of the donor's refills, with the task's own
dl_runtime and dl_period. The root domain then keeps the task's
bandwidth in total_bw for too long, or releases it too early. Until it
is released, deadline tasks that would fit are refused.
Fix this by starting a period of its own in switched_from_dl(), as
dl_deboost() does. Share that code in dl_start_own_period(). The 0-lag
time of the new period is now, or has passed, so the bandwidth is
released at once.
The Sashiko AI review found this, on "sched/deadline: Reset the
deadline and the runtime with the parameters" of the first series. The
deboost_out_after_donor_refill case, added to deadline_bw_test later in
this series, tests it. An owner of 5ms every 100ms leaves the class
while it holds the lock, and is refilled by a donor of 2ms every 10ms.
Without this patch, its bandwidth was still in total_bw right after the
unlock, in 40 runs of 40. With it, the bandwidth was gone in 60 runs of
60.
Fixes: 2d3d891d3344 ("sched/deadline: Add SCHED_DEADLINE inheritance logic")
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxxxx>
Cc: stable@xxxxxxxxxxxxxxx
---
kernel/sched/deadline.c | 29 +++++++++++++++++++++++------
1 file changed, 23 insertions(+), 6 deletions(-)
diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index 77a1d1f463f6..d284036ecb8a 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -83,6 +83,16 @@ static inline int on_dl_rq(struct sched_dl_entity *dl_se)
return !RB_EMPTY_NODE(&dl_se->rb_node);
}
+/*
+ * Start a period of the reservation of @dl_se now. The caller holds the rq
+ * lock and has updated the rq clock.
+ */
+static inline void dl_start_own_period(struct sched_dl_entity *dl_se)
+{
+ dl_se->deadline = rq_clock(rq_of_dl_se(dl_se)) + dl_se->dl_deadline;
+ dl_se->runtime = dl_se->dl_runtime;
+}
+
#ifdef CONFIG_RT_MUTEXES
static inline struct sched_dl_entity *pi_of(struct sched_dl_entity *dl_se)
{
@@ -117,12 +127,8 @@ static inline void dl_note_donor_refill(struct sched_dl_entity *dl_se)
*/
void dl_deboost(struct sched_dl_entity *dl_se)
{
- struct rq *rq = rq_of_dl_se(dl_se);
-
- if (dl_se->dl_donor_refill) {
- dl_se->deadline = rq_clock(rq) + dl_se->dl_deadline;
- dl_se->runtime = dl_se->dl_runtime;
- }
+ if (dl_se->dl_donor_refill)
+ dl_start_own_period(dl_se);
dl_drop_boost(dl_se);
}
@@ -4504,6 +4510,17 @@ void dl_clear_root_domains(void)
static void switched_from_dl(struct rq *rq, struct task_struct *p)
{
+ /*
+ * The boost of a task with parameters of its own ends, and the task
+ * leaves the class. If the boost refilled its runtime from the
+ * donor's parameters, its runtime and deadline are not those of its
+ * reservation. task_non_contending() would mix them with its own
+ * dl_runtime and dl_period. Start a period of its own instead, as
+ * dl_deboost() does. Its 0-lag time is then now, or has passed.
+ */
+ if (p->dl.dl_runtime && p->dl.dl_donor_refill)
+ dl_start_own_period(&p->dl);
+
/*
* task_non_contending() can start the "inactive timer" (if the 0-lag
* time is in the future). If the task switches back to dl before
--
2.47.3