Re: [PATCH] usb: bdc: Use devm_clk_get_optional_enabled() in bdc_probe()
From: Christophe JAILLET
Date: Thu Nov 19 2026 - 15:20:09 EST
Le 19/11/2026 à 20:06, Markus Elfring a écrit :
From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
Date: Thu, 19 Nov 2026 20:00:07 +0100
Reuse existing functionality from devm_clk_get_optional_enabled()
instead of keeping duplicate source code.
The source code was transformed by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
---
drivers/usb/gadget/udc/bdc/bdc_core.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/usb/gadget/udc/bdc/bdc_core.c b/drivers/usb/gadget/udc/bdc/bdc_core.c
index 5149c98bf9bf..ce09327250f4 100644
--- a/drivers/usb/gadget/udc/bdc/bdc_core.c
+++ b/drivers/usb/gadget/udc/bdc/bdc_core.c
@@ -530,16 +530,10 @@ static int bdc_probe(struct platform_device *pdev)
}
}
- bdc->clk = devm_clk_get_optional(dev, "sw_usbd");
+ bdc->clk = devm_clk_get_optional_enabled(dev, "sw_usbd");
if (IS_ERR(bdc->clk))
return PTR_ERR(bdc->clk);
- ret = clk_prepare_enable(bdc->clk);
- if (ret) {
- dev_err(dev, "could not enable clock\n");
- return ret;
- }
-
ret = bdc_phy_init(bdc);
if (ret) {
dev_err(bdc->dev, "BDC phy init failure:%d\n", ret);
Hi,
this patch is wrong because the remove function and the error handling path of the probe need to be updated.
CJ