[PATCH v1 05/44] dmaengine: sdxi: support timeout-aware completion waits

From: Wei Huang

Date: Thu Nov 19 2026 - 15:26:14 EST


Extend the completion status block API with interruptible and
non-interruptible timeout waits and raw flag access. These extensions
will be used by the descriptor submission code added later. In the
meanhile, keep existing CQ ownership and simple completion mode
unchanged.

Co-developed-by: Nathan Lynch <nathan.lynch@xxxxxxx>
Signed-off-by: Nathan Lynch <nathan.lynch@xxxxxxx>
Signed-off-by: Wei Huang <wei.huang2@xxxxxxx>
---
drivers/dma/sdxi/completion.c | 37 ++++++++++++++++++++++++++++-------
drivers/dma/sdxi/completion.h | 4 ++++
2 files changed, 34 insertions(+), 7 deletions(-)

diff --git a/drivers/dma/sdxi/completion.c b/drivers/dma/sdxi/completion.c
index dacd1cac6303..555a24c31341 100644
--- a/drivers/dma/sdxi/completion.c
+++ b/drivers/dma/sdxi/completion.c
@@ -7,8 +7,10 @@
#include <kunit/visibility.h>
#include <linux/bitfield.h>
#include <linux/bitmap.h>
+#include <linux/delay.h>
#include <linux/dma-mapping.h>
-#include <linux/iopoll.h>
+#include <linux/jiffies.h>
+#include <linux/sched/signal.h>
#include <linux/slab.h>
#include <linux/spinlock.h>
#include <linux/wait.h>
@@ -176,14 +178,35 @@ enum sdxi_completion_state sdxi_cst_blk_check(const struct sdxi_cst_blk *cst)

int sdxi_cst_blk_poll(const struct sdxi_cst_blk *cst)
{
+ return sdxi_cst_blk_wait_timeout(cst, USEC_PER_SEC / USEC_PER_MSEC,
+ false);
+}
+
+int sdxi_cst_blk_wait_timeout(const struct sdxi_cst_blk *cst,
+ unsigned int timeout_ms, bool interruptible)
+{
+ unsigned long deadline = 0;
enum sdxi_completion_state state;
- int ret;

- ret = read_poll_timeout(sdxi_cst_blk_check, state,
- state != SDXI_COMPLETION_PENDING,
- 10, USEC_PER_SEC, false, cst);
- if (ret)
- return ret; /* -ETIMEDOUT */
+ if (timeout_ms)
+ deadline = jiffies + msecs_to_jiffies(timeout_ms);
+
+ for (;;) {
+ state = sdxi_cst_blk_check(cst);
+ if (state != SDXI_COMPLETION_PENDING)
+ break;
+ if (interruptible && signal_pending(current))
+ return -ERESTARTSYS;
+ if (timeout_ms && time_after(jiffies, deadline))
+ return -ETIMEDOUT;
+ usleep_range(50, 200);
+ }

return state == SDXI_COMPLETION_ERROR ? -EIO : 0;
}
+
+u32 sdxi_cst_blk_flags(const struct sdxi_cst_blk *cst)
+{
+ dma_rmb();
+ return le32_to_cpu(READ_ONCE(cst->flags));
+}
diff --git a/drivers/dma/sdxi/completion.h b/drivers/dma/sdxi/completion.h
index 18c89701d1d6..9a7a0838bb3d 100644
--- a/drivers/dma/sdxi/completion.h
+++ b/drivers/dma/sdxi/completion.h
@@ -47,6 +47,10 @@ static inline void sdxi_cst_blk_init(struct sdxi_cst_blk *cst)
}

int __must_check sdxi_cst_blk_poll(const struct sdxi_cst_blk *cst);
+int __must_check sdxi_cst_blk_wait_timeout(const struct sdxi_cst_blk *cst,
+ unsigned int timeout_ms,
+ bool interruptible);
enum sdxi_completion_state sdxi_cst_blk_check(const struct sdxi_cst_blk *cst);
+u32 sdxi_cst_blk_flags(const struct sdxi_cst_blk *cst);

#endif /* DMA_SDXI_COMPLETION_H */
--
2.56.1