[PATCH v1 23/44] dmaengine: sdxi: implement typed vendor admin transport
From: Wei Huang
Date: Thu Nov 19 2026 - 15:29:41 EST
SDXI allows vendors to define vendor-specific descriptors. Add a
module-pinned GUID handler registry and a typed vendor ioctl that never
accepts raw descriptors from userspace. It probes the vendor's opcode
through SDXI discovery, delegates authorization to the registered
handler, and keeps execution on the kernel-owned admin context.
Signed-off-by: Wei Huang <wei.huang2@xxxxxxx>
---
drivers/dma/sdxi/Makefile | 3 +-
drivers/dma/sdxi/ioctl.c | 107 +++++++++++++++++++++++------
drivers/dma/sdxi/vendor.c | 138 ++++++++++++++++++++++++++++++++++++++
drivers/dma/sdxi/vendor.h | 42 ++++++++++++
4 files changed, 270 insertions(+), 20 deletions(-)
create mode 100644 drivers/dma/sdxi/vendor.c
create mode 100644 drivers/dma/sdxi/vendor.h
diff --git a/drivers/dma/sdxi/Makefile b/drivers/dma/sdxi/Makefile
index a9eaf01df4aa..253398a45c74 100644
--- a/drivers/dma/sdxi/Makefile
+++ b/drivers/dma/sdxi/Makefile
@@ -12,7 +12,8 @@ sdxi-core-y := \
ioctl.o \
keys.o \
process.o \
- ring.o
+ ring.o \
+ vendor.o
obj-$(CONFIG_SDXI_PCI) += sdxi-pci.o
sdxi-pci-y := pci.o
diff --git a/drivers/dma/sdxi/ioctl.c b/drivers/dma/sdxi/ioctl.c
index 80648bed0e87..feef322a005e 100644
--- a/drivers/dma/sdxi/ioctl.c
+++ b/drivers/dma/sdxi/ioctl.c
@@ -36,6 +36,7 @@
#include "mmio.h"
#include "process.h"
#include "sdxi.h"
+#include "vendor.h"
#define SDXI_MAX_MINORS 256
@@ -75,12 +76,6 @@ static int sdxi_file_check_owner(const struct sdxi_process *process)
return 0;
}
-static int sdxi_ioctl_unsupported(struct file *file, struct sdxi_file *sf,
- void *data)
-{
- return -EOPNOTSUPP;
-}
-
static int sdxi_ioctl_get_uapi_info(struct file *file, struct sdxi_file *sf,
void *data)
{
@@ -101,7 +96,8 @@ static int sdxi_ioctl_get_uapi_info(struct file *file, struct sdxi_file *sf,
SDXI_UAPI_CAP_CXT_CREATE |
SDXI_UAPI_CAP_CXT_EVENTFD |
SDXI_UAPI_CAP_AKEY_MGMT |
- SDXI_UAPI_CAP_ADMIN_DISC,
+ SDXI_UAPI_CAP_ADMIN_DISC |
+ SDXI_UAPI_CAP_ADMIN_VENDOR,
},
};
@@ -721,6 +717,59 @@ static int sdxi_ioctl_admin_disc(struct file *file, struct sdxi_file *sf,
return ret;
}
+static bool
+sdxi_admin_vendor_reserved_zero(const struct sdxi_admin_vendor_args *args)
+{
+ return !args->flags && !args->rsvd0 && !args->rsvd1 &&
+ sdxi_u32_array_zero(args->rsvd2, ARRAY_SIZE(args->rsvd2));
+}
+
+static unsigned int sdxi_admin_timeout(u32 timeout_ms)
+{
+ return clamp_val(timeout_ms ?: 5000U, 1U, 60000U);
+}
+
+static int sdxi_ioctl_admin_vendor(struct file *file, struct sdxi_file *sf,
+ void *data)
+{
+ struct sdxi_admin_vendor_args *args = data;
+ const struct sdxi_vendor_handler *handler;
+ struct sdxi_dev *sdxi = sf->process->sdxi;
+ unsigned int timeout_ms;
+ u16 opcode_type;
+ int ret;
+
+ if (args->argsz < sizeof(*args) ||
+ !sdxi_admin_vendor_reserved_zero(args))
+ return -EINVAL;
+
+ args->argsz = sizeof(*args);
+ args->cst_flags = 0;
+ timeout_ms = sdxi_admin_timeout(args->timeout_ms);
+
+ ret = sdxi_vendor_get(args->guid, &handler);
+ if (ret)
+ return ret;
+
+ ret = sdxi_vendor_find_opcode_type(sdxi, args->guid, timeout_ms,
+ &opcode_type);
+ if (ret)
+ goto put_handler;
+
+ if (args->op == SDXI_ADMIN_VENDOR_PROBE) {
+ if (args->in_size || args->in_uptr ||
+ args->out_size || args->out_uptr)
+ ret = -EINVAL;
+ goto put_handler;
+ }
+
+ ret = handler->ops->exec(sdxi, opcode_type, args, timeout_ms);
+
+put_handler:
+ sdxi_vendor_put(handler);
+ return ret;
+}
+
#define SDXI_IOCTL_DEF(_nr, _cmd, _func, _files, _access) \
[_nr] = { \
.cmd = (_cmd), \
@@ -759,25 +808,41 @@ static const struct sdxi_ioctl_desc sdxi_ioctls[] = {
SDXI_IOCTL_F_CONTEXT, SDXI_IOCTL_A_CONTEXT_OWNER),
SDXI_IOCTL_DEF(0x0d, SDXI_ADMIN_DISC, sdxi_ioctl_admin_disc,
SDXI_IOCTL_F_DEVICE, SDXI_IOCTL_A_PUBLIC_DEVICE),
- SDXI_IOCTL_DEF(0x0e, SDXI_ADMIN_VENDOR, sdxi_ioctl_unsupported,
+ SDXI_IOCTL_DEF(0x0e, SDXI_ADMIN_VENDOR, sdxi_ioctl_admin_vendor,
SDXI_IOCTL_F_DEVICE, SDXI_IOCTL_A_VENDOR_HANDLER),
SDXI_IOCTL_DEF(0x0f, SDXI_QUIESCE_CXT, sdxi_ioctl_quiesce_cxt,
SDXI_IOCTL_F_CONTEXT, SDXI_IOCTL_A_CONTEXT_OWNER),
};
-static int sdxi_ioctl_permit(const struct sdxi_ioctl_desc *desc)
+static int sdxi_ioctl_pre_permit(const struct sdxi_ioctl_desc *desc)
{
- switch (desc->access) {
- case SDXI_IOCTL_A_PUBLIC_DEVICE:
- case SDXI_IOCTL_A_CONTEXT_OWNER:
- return 0;
- case SDXI_IOCTL_A_ADMIN_DEVICE:
+ if (desc->access == SDXI_IOCTL_A_ADMIN_DEVICE)
return capable(CAP_SYS_ADMIN) ? 0 : -EPERM;
- case SDXI_IOCTL_A_VENDOR_HANDLER:
- return -EOPNOTSUPP;
- }
- return -EINVAL;
+ return 0;
+}
+
+static int sdxi_ioctl_permit(const struct sdxi_ioctl_desc *desc,
+ struct sdxi_file *sf, void *data)
+{
+ const struct sdxi_vendor_handler *handler;
+ struct sdxi_admin_vendor_args *args;
+ int ret;
+
+ if (desc->access != SDXI_IOCTL_A_VENDOR_HANDLER)
+ return 0;
+
+ args = data;
+ if (!args || args->argsz < sizeof(*args) ||
+ !sdxi_admin_vendor_reserved_zero(args))
+ return -EINVAL;
+
+ ret = sdxi_vendor_get(args->guid, &handler);
+ if (ret)
+ return ret;
+ ret = handler->ops->authorize(sf->process->sdxi, args);
+ sdxi_vendor_put(handler);
+ return ret;
}
static bool sdxi_ioctl_has_trailing_payload(unsigned int cmd)
@@ -900,7 +965,7 @@ static long sdxi_ioctl_live(struct file *file, unsigned int cmd,
if (!allowed)
return -ENOTTY;
- ret = sdxi_ioctl_permit(desc);
+ ret = sdxi_ioctl_pre_permit(desc);
if (ret)
return ret;
@@ -959,6 +1024,10 @@ static long sdxi_ioctl_live(struct file *file, unsigned int cmd,
}
}
+ ret = sdxi_ioctl_permit(desc, sf, data);
+ if (ret)
+ goto out;
+
ret = desc->func(file, sf, data);
if (ret == -ENOSPC && sdxi_key_list_cmd(desc->cmd))
diff --git a/drivers/dma/sdxi/vendor.c b/drivers/dma/sdxi/vendor.c
new file mode 100644
index 000000000000..6fb5967b0052
--- /dev/null
+++ b/drivers/dma/sdxi/vendor.c
@@ -0,0 +1,138 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * SDXI vendor operation handler registry.
+ *
+ * Copyright Advanced Micro Devices, Inc.
+ */
+
+#include <linux/dma-mapping.h>
+#include <linux/module.h>
+#include <linux/mutex.h>
+#include <linux/string.h>
+
+#include "admin.h"
+#include "sdxi.h"
+#include "vendor.h"
+
+static LIST_HEAD(sdxi_vendor_handlers);
+static DEFINE_MUTEX(sdxi_vendor_lock);
+
+int sdxi_vendor_register(struct sdxi_vendor_handler *handler)
+{
+ struct sdxi_vendor_handler *iter;
+ int ret = 0;
+
+ if (!handler || !handler->name || !handler->guid || !handler->ops ||
+ !handler->ops->authorize || !handler->ops->exec)
+ return -EINVAL;
+
+ if (!handler->entry.next)
+ INIT_LIST_HEAD(&handler->entry);
+
+ mutex_lock(&sdxi_vendor_lock);
+ if (!list_empty(&handler->entry)) {
+ ret = -EBUSY;
+ goto out_unlock;
+ }
+
+ list_for_each_entry(iter, &sdxi_vendor_handlers, entry) {
+ if (!memcmp(iter->guid, handler->guid, 16)) {
+ ret = -EEXIST;
+ goto out_unlock;
+ }
+ }
+
+ list_add_tail(&handler->entry, &sdxi_vendor_handlers);
+
+out_unlock:
+ mutex_unlock(&sdxi_vendor_lock);
+ return ret;
+}
+EXPORT_SYMBOL_NS_GPL(sdxi_vendor_register, "SDXI");
+
+void sdxi_vendor_unregister(struct sdxi_vendor_handler *handler)
+{
+ if (!handler)
+ return;
+ if (!handler->entry.next)
+ INIT_LIST_HEAD(&handler->entry);
+
+ mutex_lock(&sdxi_vendor_lock);
+ if (!list_empty(&handler->entry))
+ list_del_init(&handler->entry);
+ mutex_unlock(&sdxi_vendor_lock);
+}
+EXPORT_SYMBOL_NS_GPL(sdxi_vendor_unregister, "SDXI");
+
+int sdxi_vendor_get(const u8 guid[16],
+ const struct sdxi_vendor_handler **handler_out)
+{
+ const struct sdxi_vendor_handler *handler;
+ int ret = -EOPNOTSUPP;
+
+ if (!guid || !handler_out)
+ return -EINVAL;
+
+ mutex_lock(&sdxi_vendor_lock);
+ list_for_each_entry(handler, &sdxi_vendor_handlers, entry) {
+ if (memcmp(handler->guid, guid, 16))
+ continue;
+ if (!try_module_get(handler->owner))
+ break;
+
+ *handler_out = handler;
+ ret = 0;
+ break;
+ }
+ mutex_unlock(&sdxi_vendor_lock);
+
+ return ret;
+}
+
+void sdxi_vendor_put(const struct sdxi_vendor_handler *handler)
+{
+ if (handler)
+ module_put(handler->owner);
+}
+
+int sdxi_vendor_find_opcode_type(struct sdxi_dev *sdxi, const u8 guid[16],
+ unsigned int timeout_ms, u16 *opcode_type)
+{
+ const u16 first = 1;
+ const u16 last = 2047;
+ const size_t record_size = 16;
+ const size_t size = (last - first + 1) * record_size;
+ dma_addr_t dma;
+ u8 *records;
+ u16 index;
+ int ret;
+
+ if (!sdxi || !guid || !opcode_type)
+ return -EINVAL;
+ if (!sdxi_dev_compatible(sdxi, SDXI_VERSION_1_1))
+ return -EOPNOTSUPP;
+
+ records = dma_alloc_coherent(sdxi->dev, size, &dma, GFP_KERNEL);
+ if (!records)
+ return -ENOMEM;
+
+ ret = sdxi_adm_disc(sdxi, first, last, dma, timeout_ms, NULL);
+ if (ret)
+ goto free_records;
+
+ dma_rmb();
+ for (index = first; index <= last; index++) {
+ const u8 *record = records + (index - first) * record_size;
+
+ if (!memcmp(record, guid, record_size)) {
+ *opcode_type = index;
+ ret = 0;
+ goto free_records;
+ }
+ }
+ ret = -EOPNOTSUPP;
+
+free_records:
+ dma_free_coherent(sdxi->dev, size, records, dma);
+ return ret;
+}
diff --git a/drivers/dma/sdxi/vendor.h b/drivers/dma/sdxi/vendor.h
new file mode 100644
index 000000000000..2a4e4582b21b
--- /dev/null
+++ b/drivers/dma/sdxi/vendor.h
@@ -0,0 +1,42 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/*
+ * SDXI vendor operation handler registry.
+ *
+ * Copyright Advanced Micro Devices, Inc.
+ */
+
+#ifndef DMA_SDXI_VENDOR_H
+#define DMA_SDXI_VENDOR_H
+
+#include <linux/list.h>
+#include <linux/module.h>
+#include <linux/types.h>
+
+struct sdxi_admin_vendor_args;
+struct sdxi_dev;
+
+struct sdxi_vendor_handler_ops {
+ int (*authorize)(struct sdxi_dev *sdxi,
+ const struct sdxi_admin_vendor_args *args);
+ int (*exec)(struct sdxi_dev *sdxi, u16 opcode_type,
+ struct sdxi_admin_vendor_args *args,
+ unsigned int timeout_ms);
+};
+
+struct sdxi_vendor_handler {
+ struct list_head entry;
+ const char *name;
+ const u8 *guid;
+ struct module *owner;
+ const struct sdxi_vendor_handler_ops *ops;
+};
+
+int sdxi_vendor_register(struct sdxi_vendor_handler *handler);
+void sdxi_vendor_unregister(struct sdxi_vendor_handler *handler);
+int sdxi_vendor_get(const u8 guid[16],
+ const struct sdxi_vendor_handler **handler);
+void sdxi_vendor_put(const struct sdxi_vendor_handler *handler);
+int sdxi_vendor_find_opcode_type(struct sdxi_dev *sdxi, const u8 guid[16],
+ unsigned int timeout_ms, u16 *opcode_type);
+
+#endif /* DMA_SDXI_VENDOR_H */
--
2.56.1